Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@gatorsmile @cloud-fan @viirya @HyukjinKwon Thanks a lot! =)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152429647
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,231 @@
+/*
+ * Licensed
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
Thanks for everyone's comments! I have polished the test cases.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421950
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152422048
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421982
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,9 +296,15 @@ class JDBCSuite extends SparkFunSuite
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152421773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@cloud-fan Thank you for your comments! I have updated the test cases as
you suggested.
---
-
To unsubscribe, e-mail: reviews
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193847
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,306 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193833
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191430
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152186116
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152158653
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152137096
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152136470
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object DataSourceStrategy
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151922970
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object DataSourceStrategy
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151920447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object DataSourceStrategy
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151920126
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,11 @@ object DataSourceStrategy
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@viirya I'm fine with backport to 2.2 unless anyone objects.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151901160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,10 @@ object DataSourceStrategy
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@viirya Thanks for letting me know, Simon. I've fixed the title. Can
someone please help trigger the tests please
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/19776
[SPARK-22548][SQL] Incorrect nested AND expression pushed down to JDBâ¦
â¦C data source
## What changes were proposed in this pull request?
Letâs say I have a nested
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9920#issuecomment-218837337
@holdenk Definitely :-) Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9920#issuecomment-218826896
Yes. I'd like to continue working on this. But since this PR is obsolete. I
will close it and open a new one instead.
---
If your project is set up for it, you can
Github user jliwork closed the pull request at:
https://github.com/apache/spark/pull/9920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-214459899
Awesome. Thank you! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-212281661
@rxin gentle ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209606539
@rxin Microsoft SQL Server, IBM DB2 and Sybase Adaptive Server support
them.
https://msdn.microsoft.com/en-us/library/ms188074.aspx
http://www.ibm.com
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/12316#discussion_r59323956
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/12316
[SPARK-14548][SQL] Support not greater than and not less than operator in
Spark SQL
## What changes were proposed in this pull request?
!< means not less than which is equival
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9920#issuecomment-160546154
@jkbradley @holdenk Could you please take a look my latest fix and let me
know of any further comments? thanks!
---
If your project is set up for it, you can reply
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/9920
[SPARK-11569] [ML] Fix StringIndexer to handle null value properly
I was having some problem with rebase on
https://github.com/apache/spark/pull/9709, so I had to close that PR and
creating a new
Github user jliwork closed the pull request at:
https://github.com/apache/spark/pull/9709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9709#issuecomment-159098271
@dragos thanks for pointing it out. i am having some problem with rebase
and will close this PR.
---
If your project is set up for it, you can reply to this email
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9709#issuecomment-157152669
@mengxr @jkbradley Can you please help to take a look at my fix? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/9709
[SPARK-11569] [ML] Fix StringIndexer to handle null value properly
The root cause of this bug is that StringIndexer is unable to handle input
column with null value. With my fix, null value can
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9247#issuecomment-151274333
@marmbrus @cloud-fan Thank you for your comment. My current fix takes care
of array of NullType. I should be able to give error to block sort_array on
struct type
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/9247#discussion_r43074419
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionFunctionsSuite.scala
---
@@ -64,6 +65,21 @@ class
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9247#issuecomment-151341426
Thank you all. I have updated my fix based on your comments. It should now
be able to:
1) skip sorting an array of NULLs
2) sort an array of StructType
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9247#issuecomment-150992372
@cloud-fan Thank you very much for your comment! Sorting on array of NULL
type does not make sense to me, either. That's why my fix is to block this kind
of sorting
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/9247#issuecomment-151030490
@cloud-fan Thanks for the clarification. You have a very good point. This
bug's exception occourred because SortArray's Comparators expect AtomicType
only. According
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/9247
[SPARK-11277] [SQL] sort_array throws exception scala.MatchError
I'm new to spark. I was trying out the sort_array function then hit this
exception. I looked into the spark source code. I found
42 matches
Mail list logo
