Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/20640#discussion_r169500415
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -571,7
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/20640#discussion_r169497847
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -648,15
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17471
I think the power is still out in the CS building at Berkeley because of
the earthquake, so I'm guessing Jenkins is down as a result (note that even the
vanilla AMP website doesn't work: http
Github user kayousterhout closed the pull request at:
https://github.com/apache/spark/pull/16877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15326
@HyukjinKwon what's the ping here for? It looks like I left some comments
that @erenavsarogullari will address when he has time.
---
If your project is set up for it, you can reply
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17543
In theory (as you may know), the way this is supposed to work is that,
since each reduce task reads the map outputs in random order, we delay
re-scheduling the earlier stage, to try
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17543#discussion_r110014380
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1281,10 +1281,24 @@ class DAGScheduler(
val
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17543#discussion_r110010527
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1281,10 +1281,24 @@ class DAGScheduler(
val
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17543#discussion_r110009919
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1281,10 +1281,24 @@ class DAGScheduler(
val
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17533
I'm hesitant about this and posted some comments on the JIRA (we should try
to keep high-level discussion about whether this change makes sense there, so
it's easier to reference
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17445
Jenkins this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15326#discussion_r109322968
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15326#discussion_r109323006
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15326#discussion_r109322987
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15326#discussion_r109322980
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15326
Jenkins this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17445
Have you seen #17088? I just glanced at this quickly but I think this is a
duplicate of that (SPARK-19753)
---
If your project is set up for it, you can reply to this email and have your
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17445
Jenkins this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17208
LGTM merged this to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17297
Agree sounds good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17448
Thanks @gatorsmile!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17297
@sitalkedia they're in core/target/unit-tests.log
Sometimes it's easier to move the logs to the tests (so they show up
in-line), which you can do by changing core/src/test/resources
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17297
To recap the issue that Imran and I discussed here, I think it can be
summarized as follows:
- A Fetch Failure happens at some time t and indicates that the map output
on machine M
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
test changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
Left an inline comment to eliminate the brittle Thread.sleep that remains
in the test (posting here to make sure this doesn't get lost!)
---
If your project is set up for it, you can reply
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17325#discussion_r108254598
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
---
@@ -481,27 +481,39 @@ class
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17208
Yes can you also merge @squito's test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17166
I merged this to master. I realized that the PR description is still from
an old version of the change, so I modified the commit message to add that this
also adds
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16867
Merged this to master -- thanks for all of the quick updates here
@jinxing64!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17297
@sitalkedia can you file a JIRA in the future when you see flaky test
failures? In this case I updated an existing JIRA
(https://issues.apache.org/jira/browse/SPARK-19612) but please do
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17325#discussion_r107821258
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
---
@@ -481,27 +481,39 @@ class
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
LGTM merged into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15326
@erenavsarogullari is this ready to be updated now that #16813 has been
merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812908
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812876
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812807
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812986
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812930
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r107812584
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -893,6 +893,7 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17208
@liujianhuiouc have you had time to fix this up yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17166
LGTM -- this looks great. Thanks for coming up with a simple way to
address @mridulm's feedback Eric!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107778618
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107776242
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107776906
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107740806
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
It looks like this is actually fixing a bug in addition to updating the
test. Is it possible to write a unit test for the bug? In any case, can you
update the JIRA to describe the bug
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
Jenkins, this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107561714
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -296,12 +298,13 @@ private[spark] class Executor
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins, this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17166
LGTM. I'll merge once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107552896
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -215,7 +215,7 @@ private[spark] class PythonRunner
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107553383
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -239,14 +239,26 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107553047
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -296,12 +298,13 @@ private[spark] class Executor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107541348
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107534312
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -239,14 +239,21 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107539290
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107533896
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -239,14 +239,21 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107539016
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107533603
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -239,14 +239,21 @@ private[spark] class TaskSchedulerImpl
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107531839
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -426,15 +427,17 @@ private[spark] class Executor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107533097
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -160,15 +160,20 @@ private[spark] abstract class Task[T
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107533292
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -160,15 +160,20 @@ private[spark] abstract class Task[T
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107528922
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -215,7 +215,7 @@ private[spark] class PythonRunner
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107528253
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -59,8 +59,8 @@ private[spark] class TaskContextImpl(
/** List
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17338
@srowen I think #17344 was intended to be for a different JIRA and was
accidentally assigned the same JIRA# as this PR (although they are related
issues).
---
If your project is set up
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17344
Also @gatorsmile don't forget to update the corresponding JIRA when you
merge a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17344
It looks like this has the wrong JIRA id and should be SPARK-19988? I've
marked that jira as resolved by this PR, but let me know if I've misunderstood
things here.
---
If your project
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17166
I realized you could also just let the task reason be the empty string (or
some default reason) in the Executor code. That involves changing fewer LOC
but doesn't seem like the right long
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17088
Ok that makes sense. I wanted to make sure that there wasn't some bug in
SlaveLost (which might lead to a simpler fix than this) but @squito's
description makes it clear
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17088
One meta question here: why aren't we getting a SlaveLost message in this
case? I'm asking since there's already code in #14931 to un-register shuffle
service files when we get a SlaveLost
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17095
Sounds like this was caused by a different PR (see the comment on the JIRA)
and is now being fixed, so never mind here!
---
If your project is set up for it, you can reply to this email
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17095
I suspect that this PR is the cause of consistent failures in the maven
build, in the HiveCatalogedDDLSuite unit test:
https://spark-tests.appspot.com/test-details?suite_name
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17307
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17307
@squito FYI I filed a JIRA for the 2nd of the two unit tests that failed in
that run (looks like you'd already filed a JIRA for the first one)
---
If your project is set up for it, you can
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r106555744
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -710,7 +710,11 @@ private[spark] class TaskSetManager
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r106555639
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2250,6 +2250,22 @@ class SparkContext(config: SparkConf) extends
Logging
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17166
Thinking about this more, this seems like two separate changes (that should
probably be separated):
(1) Allowing cancellations to be injected via SparkContext. This seems
like
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106337950
--- Diff: docs/configuration.md ---
@@ -1506,6 +1506,11 @@ Apart from these, the following properties are also
available, and may be useful
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17307
@sitalkedia please do not ignore flaky test failures. I updated the JIRA
associated with this one:
https://issues.apache.org/jira/browse/SPARK-19803?jql=project%20%3D%20SPARK%20AND%20labels
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106305175
--- Diff: docs/configuration.md ---
@@ -1506,6 +1506,11 @@ Apart from these, the following properties are also
available, and may be useful
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15604
Thanks for your work on this @erenavsarogullari. I've merged this into
master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106298407
--- Diff: docs/configuration.md ---
@@ -1506,6 +1506,11 @@ Apart from these, the following properties are also
available, and may be useful
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106298013
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultStage.scala
---
@@ -34,8 +34,10 @@ private[spark] class ResultStage(
val
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106298195
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -187,6 +187,11 @@ class DAGScheduler(
/** If enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106298559
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -187,6 +187,11 @@ class DAGScheduler(
/** If enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106297948
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
@@ -59,6 +59,7 @@ private[scheduler] abstract class Stage(
val
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17307#discussion_r106297978
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala ---
@@ -41,9 +41,10 @@ private[spark] class ShuffleMapStage
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11254#discussion_r106293790
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
@@ -118,7 +119,7 @@ private[scheduler] abstract class Stage
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11254#discussion_r106292588
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
@@ -58,6 +58,7 @@ private[scheduler] abstract class Stage(
val
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11254#discussion_r106292533
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
@@ -145,6 +146,6 @@ private[scheduler] abstract class Stage
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11254#discussion_r106292014
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -180,6 +180,11 @@ class DAGScheduler(
/** If enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/11254
GIven discussion with @sitalkedia on other PRs I agree that it makes sense
to add now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16905#discussion_r106244124
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -73,17 +73,15 @@ class TaskSchedulerImplSuite extends
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17297
@sitalkedia I won't have time to review this in detail for at least a few
weeks, just so you know (although others may have time to review / merge it).
At a very high level, I'm
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r106235234
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -911,17 +919,16 @@ private[spark] class TaskSetManager
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r106237592
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/MedianHeap.scala ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 1796 matches
Mail list logo
