Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r228601036
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -62,6 +62,8 @@ public UnsafeSorterSpillWriter
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r228598058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22818
Thanks, would it be also possible to double-check `Integer.MAX_VALUE` if
you have not checked yet?
---
-
To unsubscribe, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r227780781
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
ConfigBuilder
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r227729436
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
ConfigBuilder
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22798
Based on bash syntax, this change makes sense. I would like to wait for
@vanzin 's comment.
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r227363331
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
ConfigBuilder
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22803
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Sorry for my mistake. My keyboard '4' sometimes has a trouble.
> I think, INT_MAX is 2147483647, so n ~= sqrt(2*2147483647) = 65
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22800
cc @cloud-fan @gatorsmile @HyukjinKwon @xuanyuanking
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22800
[SPARK-24499][SQL][DOC][follow-up] Fix spelling in doc
## What changes were proposed in this pull request?
This PR replaces `turing` with `tuning` in files and a file name.
Currently
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
One question: After this PR, what is the maximum column that we can accept?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Can I clarify the description?
> Because we are passing an array of size n*(n+1)/2 to the breeze library
and the size cannot be more than INT_MAX. so, the maximum column size we can
g
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22789
Thank you for submitting a PR. Would it be possible to add a test case, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r226872137
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
ConfigBuilder
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22754
Thank you for your clarification.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r226871894
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -62,6 +62,8 @@ public UnsafeSorterSpillWriter
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22765
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22765
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22782
I will visit here tomorrow morning in Japan.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22782
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22782
Thank you for this hot fix. I found `0xc2` after `#` in
`docker-image-tool.sh` where @HyukjinKwon fixed.
```
> git log | head -1
commit fc9ba9dcc6ad47fbd05f093b94e7e1358
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22782#discussion_r226833103
--- Diff: dev/run-tests.py ---
@@ -551,7 +551,8 @@ def main():
if not changed_files or any(f.endswith(".
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22782#discussion_r226833042
--- Diff: python/pyspark/__init__.py ---
@@ -16,7 +16,7 @@
#
"""
-PySpark is the Python API for Spark.
+PySpark is
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22782#discussion_r226833028
--- Diff: dev/run-tests.py ---
@@ -551,7 +551,8 @@ def main():
if not changed_files or any(f.endswith(".
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22501
Thanks, I found `0xc2` in `docker-image-tool.sh`. I will put my finding
into #22782
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22501
Is
[this](https://github.com/apache/spark/pull/22748#issuecomment-431512558) the
oldest test failure related to this type of failure
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22501
Thanks, when it was successful, this is a part of log from
[this](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97378/consoleText)
```
copying pyspark/streaming/util.py
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22501
I am looking at each commit from the latest to old at
https://github.com/apache/spark/commits/master
---
-
To unsubscribe, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22750
You are right. Sorry, nvm
> DataSourceScanExec does not have needsUnsafeRowConversion
---
-
To unsubscribe, e-mail: revi
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22750
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22750
I thought about the last line
> This PR removes ColumnarBatchScan.needsUnsafeRowConversion, and keep this
flag only in FileSourceScanE
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22750
Do we need to update the description? For example,
`needsUnsafeRowConversion` exists in `DataSourceScanExec` now
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22754
Good catch.
One question: can we set `12` into this property?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226263066
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -0,0 +1,520 @@
+---
+layout: global
+title: Spark SQL Upgrading Guide
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226262995
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -0,0 +1,520 @@
+---
+layout: global
+title: Spark SQL Upgrading Guide
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226250306
--- Diff: docs/sql-performance-turing.md ---
@@ -0,0 +1,151 @@
+---
+layout: global
+title: Performance Tuning
+displayTitle: Performance
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226247607
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -0,0 +1,520 @@
+---
+layout: global
+title: Spark SQL Upgrading Guide
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226246375
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -0,0 +1,520 @@
+---
+layout: global
+title: Spark SQL Upgrading Guide
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226245945
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -0,0 +1,520 @@
+---
+layout: global
+title: Spark SQL Upgrading Guide
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226241683
--- Diff: docs/sql-distributed-sql-engine.md ---
@@ -0,0 +1,85 @@
+---
+layout: global
+title: Distributed SQL Engine
+displayTitle
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226239048
--- Diff: docs/sql-data-sources-parquet.md ---
@@ -0,0 +1,321 @@
+---
+layout: global
+title: Parquet Files
+displayTitle: Parquet Files
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226237047
--- Diff: docs/sql-data-sources-parquet.md ---
@@ -0,0 +1,321 @@
+---
+layout: global
+title: Parquet Files
+displayTitle: Parquet Files
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226235672
--- Diff: docs/sql-data-sources-load-save-functions.md ---
@@ -0,0 +1,283 @@
+---
+layout: global
+title: Generic Load/Save Functions
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226231876
--- Diff: docs/sql-data-sources-jdbc.md ---
@@ -0,0 +1,223 @@
+---
+layout: global
+title: JDBC To Other Databases
+displayTitle: JDBC
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r226227872
--- Diff: docs/sql-data-sources.md ---
@@ -0,0 +1,42 @@
+---
+layout: global
+title: Data Sources
+displayTitle: Data Sources
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22755
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22617
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22729
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22705
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22705
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22708
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22708#discussion_r225440522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -30,6 +30,7 @@ import
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22662#discussion_r225000849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -259,10 +259,10 @@ class ContinuousStressSuite
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
@HyukjinKwon sorry for being late. I was swampped with several things. I
have just submitted it. Looking forward to seeing feedback
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22662#discussion_r224977443
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -259,10 +259,10 @@ class ContinuousStressSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22705#discussion_r224977082
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -195,7 +196,11 @@ object ChunkedByteBuffer {
val is = new
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22711
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22698
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22678
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22678
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22678
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224549100
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224549012
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22657
Sorry for bothering you again. Do we need to apply the same reduction to
`CastSuite`?
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22657
How about defining this subset in `object DateTimeTestUtils` like
`ALL_TIMEZONES`?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22657
Do we need to apply the same reduction to `CastSuite`?
I believe that `DateTimeUtilsSuite` should check all of the time zones, but
may skip some values between`-2` to `2
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22347
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r22445
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224333028
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224332828
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224332984
--- Diff: docs/building-spark.md ---
@@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g.
2.12.6):
./build/sbt -Dscala.version
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r223917766
--- Diff: dev/run-tests-jenkins.py ---
@@ -39,7 +39,8 @@ def print_err(msg):
def post_message_to_github(msg, ghprb_pull_id):
print("Attem
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r223783598
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -221,6 +227,12 @@ trait
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22630
Thanks! merging to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22630
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223478828
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -452,46 +452,68 @@ case class RangeExec(range
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223474906
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -345,6 +345,61 @@ trait CodegenSupport extends SparkPlan
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223474853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -452,46 +452,73 @@ case class RangeExec(range
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223468018
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -518,56 +521,81 @@ class SQLMetricsSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r223214130
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -221,6 +227,12 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r223169695
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -221,6 +227,12 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r223169637
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -113,7 +113,7 @@ class CodeGenerationSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r222741323
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -221,6 +227,12 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r222740882
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -69,11 +69,17 @@ trait
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22375
ping @cloud-fan @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22602
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
101 - 200 of 3561 matches
Mail list logo
