Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM, cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21859
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21087#discussion_r211080067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -164,9 +165,12 @@ case class BucketSpec
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21860
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22135
SGTM, but can we address the similar issues at once?
Even under `src/main/...`, we can see this pattern at several places
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22125
@KraFusion Sorry, I overlooked another PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
Thank you for creating a JIRA entry and for putting the result. The test
case is not available yet.
---
-
To unsubscribe, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22126
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22125
Thanks, would it possible to address similar issues? For example, in
`configurations.md`.
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
@gatorsmile Thank you for your reply. Could you elaborate on your
suggestion?
>A general suggestion. To avoid introducing the regressions, how about
implementing a new one without chang
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
For 2. and 3., it is harder to say my opinion in the comment. Let me say
short comments at first.
For 2., if I remember correctly, @viirya once wrote the API document in a
JIRA entry
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
Thank for involving me in an important thread. I was busy this morning in
Japan.
I think there are three topics in the thread.
1. Merge or revert this PR
2. Design document
3. IR
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22110#discussion_r210282476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -115,6 +115,8 @@ protected[sql] abstract class AtomicType
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r210152479
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object CodeGenerator
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22105#discussion_r210056504
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -140,8 +140,24 @@ private int copyByteBuf
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22101
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r209995159
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object CodeGenerator
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r209993118
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object CodeGenerator
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
ping @rednaxelafx
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r209878827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,98 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r209877426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
---
@@ -34,6 +36,37 @@ object ArrayData {
case a: Array
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22101#discussion_r209863964
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
---
@@ -42,16 +42,16 @@ public int compare(
while
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22101#discussion_r209855589
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
---
@@ -60,7 +60,7 @@ public int compare(
while (i
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22101#discussion_r209855528
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
---
@@ -42,16 +42,16 @@ public int compare(
while
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22101#discussion_r209855135
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
---
@@ -42,16 +42,16 @@ public int compare(
while
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22001
Just curious.
It is very interesting to me since the recent three tries consistently
cause a timeout failure at the same test.
https://amplab.cs.berkeley.edu/jenkins/job
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
@xuejianbest Could you please create a JIRA entry and add test cases to
this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209692496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r209643599
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,100 @@ class CodegenContext
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22083
[SQL][Test][Minor] Add missing codes to
ParquetCompressionCodecPrecedenceSuite
## What changes were proposed in this pull request?
This PR adds codes to ``"
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22082
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22007
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22007
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209416053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22068
Thanks. BTW, I found another instance in test, not in doc.
Do we address this in this PR? Or, do we address in another PR?
@HyukjinKwon WDYT ?
```
class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22016
#22070 addresses more typo.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22070
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22067
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22069
Do we need to update the following similar examples, too?
Column.scala
```
* {{{
* // Example: encoding gender string column into integer.
*
* // Scala
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22068
Would it be better to update a comment in `DataFrameWriter.scala`, too?
```
* `compression` (default is the value specified in
`spark.sql.parquet.compression.codec
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209180525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209178573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -170,6 +174,23 @@ object
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21994#discussion_r209147728
--- Diff: pom.xml ---
@@ -2609,6 +2609,28 @@
+
+com.github.spotbugs
+spotbugs
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
I think that this is not a data correctness issue. This may cause
unexpected program abort due to hardware memory access error.
BTW, it would be good to backport it to increase stability
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
The failure of
`org.apache.spark.sql.catalyst.expressions.JsonExpressionsSuite.from_json
missing fields` is due to passing `null` while the schema has `nullable=false`.
This inconsistency
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22059
cc @srowen @ueshin @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22059
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22058
I think that this is the last one with the following command. But, I would
like to confirm this with @ueshin.
`build/sbt -Pscala-2.12 -Phadoop-2.6 -Pkubernetes -Phive -Pmesos
-Phive
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
Good catch
LGTM with a comment: Would it be better to update comments regarding `4
bytes` with `4 or 8 bytes` in `UnsafeExternalSorter.java
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22055
LGTM
These changes are not huge. It looks non-risky.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22059
[SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12.
## What changes were proposed in this pull request?
This PR avoid the following compilation error using sbt in Scala
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22058
cc @ueshin @srowen @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22058
[SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exhaustive in
Scala-2.12.
## What changes were proposed in this pull request?
This is a follow-up pr of #22014 and #22039
We
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20184#discussion_r208993136
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -116,13 +138,18 @@ public void loadNext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r208950122
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -929,6 +955,28 @@ class DAGScheduler(
// HadoopRDD whose
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r208947201
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -203,6 +203,17 @@ class DAGScheduler(
sc.getConf.getInt
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r208946523
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -577,4 +577,17 @@ package object config {
.timeConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r208945843
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1602,6 +1602,15 @@ class SparkContext(config: SparkConf) extends
Logging
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21859
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22055
Release notes
[9.3.21](https://github.com/eclipse/jetty.project/releases/tag/jetty-9.3.21.v20170918)
[9.3.22](https://github.com/eclipse/jetty.project/releases/tag/jetty-9.3.22.v20171030
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21505
gentle ping @ssonker
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22044#discussion_r208862917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3410,6 +3410,28 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22044
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21993#discussion_r208822706
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -631,19 +631,26 @@ object ColumnPruning extends Rule
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
I created [a PR](https://github.com/apache/spark/pull/16086) to solve the
same problem.
Can this PR handle [East Asian
Width](http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
Since this change does not look minor, could you please create a JIRA entry?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22044
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21859
Good point. [These
failures](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94431/testReport/)
may show that it affects other places
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22040
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22044
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22007
This change looks non-risky to me.
cc @swoen @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22044
[SPARK-23912][SQL][Followup] Refactor ArrayDistinct
## What changes were proposed in this pull request?
This PR simplified code generation for `ArrayDistinct`. #21966 enabled code
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208677733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -142,7 +143,7 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208677695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -308,10 +319,10 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22039#discussion_r208666588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
---
@@ -273,6 +273,9 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22039#discussion_r208666245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -394,6 +394,9 @@ class MicroBatchExecution
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22041
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22040
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22040
[Minor][Doc] Fix typo
## What changes were proposed in this pull request?
This PR fixes typo regarding `auxiliary verb + verb[s]`.
## How was this patch tested?
N/A
You
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21956
@HyukjinKwon sure, I will open a PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22007
@fokko Do we need to update files under `dev/deps`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22035
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21860
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r208561981
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
401 - 500 of 3561 matches
Mail list logo
