Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21510
LGTM with one minor comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194266907
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -101,12 +101,12 @@ private[spark] abstract class WebUI
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21520
Thank you for a lot of works to update many places. It is very hard to
split it into several pieces.
Now, we are seeing several typical patterns in the all of changes, in
paticular
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Since it is Java bytecode analysis, it is available for Scala code, too.
In my quick test, findBugs overlooked a possible overflow. On the other
hand, findBugs found another redundant null check
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
@JoshRosen @cloud-fan
Here is an update.
I have just apply `findBugs` to `OffHeapColumnVector.java` and
`UnsafeArrayData.java`.
In `OffHeapColumnVector.java`, most of possible
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r193942183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -236,6 +236,76 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r193928013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r193927995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r193927508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21507
@deepaksonu Would it be possible to close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21109#discussion_r193762830
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/InMemoryUnsafeRowQueue.scala
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21505
We would appreciate it if you put the performance before and after this PR?
It would be good to use `Benchmark` class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21061
Let me think about the implementation to keep the order.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193678440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r192949349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Good questions.
For 2, at first I found one of these issues when I looked at a file. Then,
I ran `grep` command with `long .*=.*\*` and `long .*=.*\+` in `.java` file.
Then, I picked them up
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r192551411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r192548230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r192548103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,86 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r192547906
--- Diff: python/pyspark/sql/functions.py ---
@@ -1798,6 +1798,22 @@ def create_map(*cols):
return Column(jc)
+@ignore_unicode_prefix
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192546226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2189,3 +2189,302 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
cc @ueshin @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/21481
[SPARK-24452][SQL][Core] Avoid possible overflow in int add or multiple
## What changes were proposed in this pull request?
This PR fixes possible overflow in int add or multiply
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192490355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,311 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192340073
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,311 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192336364
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,311 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192331296
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,311 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r192330635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,311 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21061
ping @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21443
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r191260626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -127,6 +127,165 @@ case class MapKeys
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r191132972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -127,6 +127,176 @@ case class MapKeys
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r191132426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -127,6 +127,176 @@ case class MapKeys
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r191131809
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -127,6 +127,165 @@ case class MapKeys
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r191126615
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -127,6 +127,165 @@ case class MapKeys
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21061
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21433
Could you please add the description for this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21069#discussion_r190485891
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,123 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21419
could you please close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21069
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21406
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21401
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21401
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21391
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21394
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21266
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21266
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21409#discussion_r190231900
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala
---
@@ -0,0 +1,132
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21405#discussion_r190228283
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -120,11 +120,11 @@ class CodeBlockSuite
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21401
good catch, thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21401
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21395
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21106#discussion_r189818763
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -24,25 +24,30 @@ import
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21106
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21342#discussion_r189634704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
---
@@ -111,12 +112,18 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21374
Until now, @gatorsmile and @ueshin fixed these when we found. I am neutral
on the policy.
I would like to hear their opinion
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21376#discussion_r189465557
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -107,7 +107,20 @@ object SQLConf {
* run tests in parallel
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21361
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21376#discussion_r189458452
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21374
cc @gatorsmile @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21342
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21374
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21372
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21371
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21371
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21374
@dongjoon-hyun thank you, l will kick this later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/21374
[SPARK-24323][SQL] Fix lint-java errors
## What changes were proposed in this pull request?
This PR fixes the following errors reported by `lint-java`
```
% dev/lint-java
Using
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21367
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21061
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21073#discussion_r189423538
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -56,6 +58,93 @@ class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21322
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189376200
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -552,4 +552,26 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189366067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,141 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21361
@mgaido91 Thank you very much. Can I ask you to fix `ArrayPosition`, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21361
Great catch, thanks.
@ueshin, I will work for `ArrayPosition`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21282
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189153686
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,141 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189153410
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,141 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189153390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,141 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21050#discussion_r189153287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1882,3 +1882,141 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21061
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19449
When #21299 will be merged, I think that we can revisit this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r188950673
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -186,6 +186,37 @@ class ComplexTypeSuite
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21342
Basically, I agree with this two-step direction. However, I think that it
is too risky to simply throw and catch `SparkException`. This is because other
`SparkException` may be caught in step 2
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21252
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
801 - 900 of 3561 matches
Mail list logo
