Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21342
The change looks good.
Is it better to add a comment that describes why we throw `SparkException`
instead of `OOM` with a reference to `scala/bug#9554`. In the future, we would
throw OOM if scala
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21069#discussion_r188704602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,104 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21069#discussion_r188704502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,104 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r188401185
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -186,6 +186,37 @@ class ComplexTypeSuite
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18903
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21316
Is it better to update title and the PR description, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21109#discussion_r188264496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -131,13 +134,101 @@ object ExtractEquiJoinKeys extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r188190407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -90,6 +90,110 @@ case class MapKeys(child
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21266#discussion_r188179709
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataSourceReadBenchmark.scala ---
@@ -0,0 +1,826 @@
+/*
+ * Licensed to the Apache Software
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21193
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187872304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21311#discussion_r187857950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -568,13 +568,16 @@ private[execution] final class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21311#discussion_r187857852
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -568,13 +568,16 @@ private[execution] final class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21301#discussion_r187808776
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/partitioning/Distribution.java
---
@@ -22,7 +22,8
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21246#discussion_r187759378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala
---
@@ -0,0 +1,569 @@
+/*
+ * Licensed
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21301
@dongjoon-hyun thanks, done
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187692007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r187690481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +119,161 @@ case class MapValues
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r187689540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +119,161 @@ case class MapValues
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21252#discussion_r187677723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1238,6 +1238,15 @@ object SQLConf {
.booleanConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21246#discussion_r187671225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala
---
@@ -0,0 +1,569 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21246#discussion_r187667028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala
---
@@ -0,0 +1,569 @@
+/*
+ * Licensed
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21301
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/21301
[SPARK-24228][SQL] Fix Java lint errors
## What changes were proposed in this pull request?
This PR fixes the following Java lint errors due to importing unimport
classes
```
[ERROR
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187651050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/ReadOnlySQLConf.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21230
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21118
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21291
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r187350669
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -621,6 +621,17 @@ class PlannerSuite extends SharedSQLContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r187294411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -529,6 +564,272 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21282#discussion_r187234431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +120,229 @@ case class MapValues
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21276
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21251
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21193
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r186611074
--- Diff: python/pyspark/sql/functions.py ---
@@ -1798,6 +1798,22 @@ def create_map(*cols):
return Column(jc)
+@ignore_unicode_prefix
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21155#discussion_r186501267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1472,390 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r186489614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,69 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r186464404
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,69 @@ case class CreateMap
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r186433318
--- Diff: python/pyspark/sql/functions.py ---
@@ -1798,6 +1798,22 @@ def create_map(*cols):
return Column(jc)
+@ignore_unicode_prefix
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21258#discussion_r186418197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -235,6 +235,69 @@ case class CreateMap
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21251
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21258
I prepared this function using the different name from `map` in Presto.
Any good idea (e.g. other names or another implemention in `map`) would be
appreciated
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/21258
[SPARK-23933][SQL] Add map_fromarray function
## What changes were proposed in this pull request?
The PR adds the SQL function `map_fromarray`. The behavior of the function
is based
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186307162
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala
---
@@ -0,0 +1,90
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21251
cc @jiangxb1987 @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/21251
[SPARK-10878][core] Fix race condition when multiple clients resolves
artifacts at the same time
## What changes were proposed in this pull request?
When multiple clients attempt to resolve
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r186283042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -19,13 +19,42 @@ package
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186246741
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -413,6 +413,25 @@ class DataFrameFunctionsSuite extends QueryTest
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18801
I can take over this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186153677
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -413,6 +413,25 @@ class DataFrameFunctionsSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186149012
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -413,6 +413,25 @@ class DataFrameFunctionsSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r186133103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -378,6 +378,138 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186126547
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -413,6 +413,25 @@ class DataFrameFunctionsSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r186097518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -378,6 +378,138 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186096582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r18607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186061995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186060660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186059899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,16 @@ case class MapValues
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186022301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -147,7 +148,40 @@ case class SortPrefix(child
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186021674
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala
---
@@ -0,0 +1,82
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186020638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186020180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,132 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186020256
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class Flatten
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21193
Overall, I like this direction to have Java code in a structure instead of
flat string.
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r185995523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185962223
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,132 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185861349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185860581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185858002
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21187
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21073#discussion_r185851612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -116,6 +117,169 @@ case class MapValues
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r185840044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -19,14 +19,41 @@ package
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21021
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21223
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21021
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21031
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21054#discussion_r185564388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/regression.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21031
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21054#discussion_r185448281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/regression.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21021
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21197
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21031
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21187
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21201
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21206
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21064
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185378543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray
901 - 1000 of 3561 matches
Mail list logo
