Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r239990434
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala
---
@@ -16,10 +16,13
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23252
@vanzin
> (Also, another nit, Spark authentication is not necessarily SASL-based.)
The security doc was updated to reflect this. Tha
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r239944338
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -380,6 +400,12 @@ private[spark] class SecurityManager
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23252
> How is this file protected in kubernetes?
More precisely it's a core concept in Kubernetes that container boundaries
provide strong enough isolation such that data doesn't leak betw
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23252
@tgravescs thanks for the feedback!
> How is this file protected in kubernetes?
One can mount secrets into files in Kubernetes, and it's up to Kubernetes
to mount these secur
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23174#discussion_r239894356
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -87,44 +88,61
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r239884995
--- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala
---
@@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23252
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23174#discussion_r239702559
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -87,44 +88,61
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r239701821
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -367,11 +372,26 @@ private[spark] class SecurityManager(
case
GitHub user mccheah opened a pull request:
https://github.com/apache/spark/pull/23252
[SPARK-26239] File-based secret key loading for SASL.
## What changes were proposed in this pull request?
This proposes an alternative way to load secret keys into a Spark
application
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23252
@vanzin @vinooganesh @ifilonenko
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23174#discussion_r239694862
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -87,44 +88,61
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
Ok that's fine. Will merge to master if there are no further comments in
the near future.
---
-
To unsubscribe, e-mail: reviews
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
It matters because we're discussing direction - that is, what opinion Spark
wants to take regarding how to set up security on K8s. It's not obvious from
our discussion on SPARK-26239 that we agree
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
Ok that's fine, with the caveat that we merge the subsequent optionality
soon. I'll work on the file-based secret authentication and encryption this
week. I'm very concerned that we'll ship
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
It's just to have the assurance that we will have some way to bypass this
for auth at least for 3.x. I'd like to concretely determine this before merging
if possible. But I hope that the suggestion
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
I think as long as we have one alternate mechanism proposed in SPARK-26239
this is ok to merge. I proposed one in [this
comment](https://issues.apache.org/jira/browse/SPARK-26239?focusedCommentId
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22959
Ah I forgot to merge, sorry! Merging into master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23057
Is this ready to merge?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r238036776
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/PartitionTransforms.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237985697
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237979620
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/v2/V1MetadataTable.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237978582
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21306
@stczwd that's my understanding yeah. Others can feel free to correct me
otherwise.
---
-
To unsubscribe, e-mail: reviews
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
The trouble is the API proposed here and how it would have to change for
future features. If we wanted to add the optionality to support authentication
via mounted files later, then what's the API
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
> There doesn't need to be a single solution. This patch going in does not
preclude adding more features later, one of which might be reading this from a
pre-defined secret.
The way i
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21306
@stczwd my understanding here is that a table isn't a streaming table or a
batch table, but rather that a table points to data that can either be scanned
in stream or in batch, and that the table
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237721926
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237723417
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Table.java ---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237722772
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/PartitionTransforms.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237723294
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Table.java ---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237723354
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Table.java ---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237722264
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/v2/V1MetadataTable.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237722352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/v2/V1MetadataTable.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237711409
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/CatalogProvider.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22959
Given that `Utils.isTesting` is used elsewhere, I'm fine with merging this.
Going to in a few hours if there are no further comments
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21978#discussion_r237656841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala ---
@@ -18,48 +18,106 @@
package org.apache.spark.sql.catalyst
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
> Why? And how are mounted files better?
Environment variables leak far more easily than file contents. One can
accidentally `printenv` in a shell attached to the and get the sec
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
Would it be possible to also provide support for passing this via a mounted
file? Some users would prefer to avoid propagating sensitive information via
environment variables. Also the user should
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21978#discussion_r237578911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala ---
@@ -18,48 +18,106 @@
package org.apache.spark.sql.catalyst
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21978#discussion_r237578805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala ---
@@ -18,48 +18,106 @@
package org.apache.spark.sql.catalyst
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r237313976
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -112,125 +72,139 @@ private[spark] case
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r236500170
--- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r236490800
--- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21978
Wanted to follow up here - are we planning on merging this or are there
more things we need to discuss?
---
-
To unsubscribe, e
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23053
Ok that makes sense. I will merge this into master then.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23053
So now the utility must always build the Java image, and optionally will
build python and R - is that correct? Is there any way to opt-out of building
Java
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23053
My understanding is that K8s is still marked as experimental, and something
like this can be changed with the expectation that we're hardening in 3.0. If
anything, we should be making this breaking
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23053
Hm, reviewing this again I think a better way to do it is to only opt-in to
building images of different bindings. So for example the Python image should
only be built when `-p ` is specified
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r234793177
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/TableProvider.java ---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23013
The SASL mechanisms still work, though it's more similar to something like
standalone mode than having the robustness of YARN. We could generate the SASL
secrets and put them in K8s secrets
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r234736735
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/TableProvider.java ---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r234736935
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Batch.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22547
@cloud-fan @rdblue I believe we've converged on an appropriate API as per
our last sync. Do we have a plan to move this forward, with the separated
smaller patches
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233257218
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233198612
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23013
I'm curious as to how much specific K8s guidance we should be giving in
Spark documentation. There is such a thing as over-documenting; though we
should certainly bias towards writing more
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22760
This looks good to me. @vanzin want to sign off?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22547#discussion_r230973917
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousInputStream.scala
---
@@ -46,17 +45,22 @@ import
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r230973235
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableChange.java ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r230972839
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Table.java ---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230965800
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
---
@@ -63,4 +63,66
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230942826
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
---
@@ -63,4 +63,66
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230941006
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230941669
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22946
@cloud-fan for review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22946
Ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22897
Ok, I am merging into master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22547#discussion_r230505785
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousInputStream.scala
---
@@ -46,17 +45,22 @@ import
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230476657
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -96,22 +96,6 @@ case "$SPARK_K8
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22608
It depends on how we're getting the Hadoop images. If we're building
everything from scratch, we could run everything in one container - though
having a container run more than one process
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22608
> You seem to be running different pods for KDC, NN and DN. Is there an
advantage to that?
>
> Seems to me you could do the same thing with a single pod and simplify
th
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230181127
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230167668
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22909
Maybe @srowen on the SBT side?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22145
Just wanted to ping on this - how close are we to getting this working on
CI?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r230127363
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -23,6 +23,18 @@ import
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22760
In that case @ifilonenko can we add said test here? Seems like the right
place to do it.
---
-
To unsubscribe, e-mail: reviews
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230119272
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230115856
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -47,10 +48,24
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230119092
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230115469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22909
Looks good to me but would like +1 from someone more familiar with SBT.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22909#discussion_r230113708
--- Diff: resource-managers/kubernetes/integration-tests/pom.xml ---
@@ -145,14 +145,10 @@
test
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230109316
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/kerberos/KerberosPVWatcherCache.scala
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230109287
--- Diff:
resource-managers/kubernetes/integration-tests/kerberos-yml/kerberos-set.yml ---
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22760
I know that `HadoopBootstrapUtil` is being reworked soon - is it worth
adding a unit test for that class here? @vanzin
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22805
Yes, this can be merged. Going into master now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22911
@ifilonenko @skonto
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r229512765
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -63,6 +66,8 @@ private
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22146
Ok I'm going to merge this into master. Thanks everyone for the feedback.
Follow up discussions around validation can be addressed in follow up patches
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229367166
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229367415
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -16,11 +16,17
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22146
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22146
@shaneknapp can we get help diagnosing the permission denied error on the
Jenkins box?
---
-
To unsubscribe, e-mail: reviews
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22146
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229024855
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229013867
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229013753
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,22 @@ To use a secret through an environment variable use
the following options
1 - 100 of 946 matches
Mail list logo
