Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
Thanks, @HyukjinKwon @jsnowacki @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@jsnowacki I have already add comments to explain the quotes, could you
help me review the comments? Thanks
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@jsnowacki Thanks for reviewing this PR! There are some situations people
cannot omit the quotes, such as multiple parameters of
"--driver-java-options". For example: [passing m
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/9183
Thanks for you job! @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/9183
@WeichenXu123 Any activity for the new PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
I design two groups test cases:
- Test cases about windows command scripts options
- Examples in Spark Document
All these test cases works well.
## Test cases
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
ok, I will give more test cases later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@HyukjinKwon Thanks for your review! Should I provide more test cases to
cover the potential corner cases?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user minixalpha opened a pull request:
https://github.com/apache/spark/pull/19090
[SPARK-21877][DEPLOY, WINDOWS] Handle quotes in Windows command scripts
## What changes were proposed in this pull request?
All the windows command scripts can not handle quotes
