[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-27 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20900 @icexelloss as a daily user of `pandas_udf`, the inability to use keyword arguments, and the difficulties around default arguments (due in part to the magic that converts string arguments

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-26 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20900 Partials (and callable objects) are supported in UDF but not `pandas_udf`; kw args are not supported by either

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-25 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20900 Many (though not all, I don't think `callable`s are impacted) of the limitations of pandas_udf relative to UDF in this domain are due to the fact that `pandas_udf` doesn't allow for keyword

[GitHub] spark pull request #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `p...

2018-03-25 Thread mstewart141
Github user mstewart141 closed the pull request at: https://github.com/apache/spark/pull/20798 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-25 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20798 see https://github.com/apache/spark/pull/20900 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-24 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20900 @HyukjinKwon the old pr: https://github.com/apache/spark/pull/20798 was a disaster from a git-cleanliness perspective so i've updated here

[GitHub] spark pull request #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `p...

2018-03-24 Thread mstewart141
GitHub user mstewart141 opened a pull request: https://github.com/apache/spark/pull/20900 [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_udf` with keyword args ## What changes were proposed in this pull request? Add documentation about the limitations

[GitHub] spark issue #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-20 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20798 all that makes sense; i will update. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-18 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20798 @HyukjinKwon thanks again. i've updated this PR to add documentation. I dug pretty deep into the bigger issue around kwargs/partial functions, and you can see what i did in the commit

[GitHub] spark issue #20798: [SPARK-23645][PYTHON] Allow python udfs to be called wit...

2018-03-11 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20798 [WIP] cc @HyukjinKwon 👍 i'd love to run tests here to make sure i haven't broken something. i will update pr with new tests once i set up testing better on my local box

[GitHub] spark pull request #20798: [SPARK-23645][PYTHON] Allow python udfs to be cal...

2018-03-11 Thread mstewart141
GitHub user mstewart141 opened a pull request: https://github.com/apache/spark/pull/20798 [SPARK-23645][PYTHON] Allow python udfs to be called with keyword arguments ## [WIP] ## What changes were proposed in this pull request? Currently one can not pass keyword

[GitHub] spark issue #20728: [SPARK-23569][PYTHON] Allow pandas_udf to work with pyth...

2018-03-04 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20728 your test definitely makes sense; yea the syntax error in py2 part is why i wasn't sure how to go about testing this in the first place. this certainly gets the job done

[GitHub] spark pull request #20728: [SPARK-23569][PYTHON] Allow pandas_udf to work wi...

2018-03-04 Thread mstewart141
Github user mstewart141 commented on a diff in the pull request: https://github.com/apache/spark/pull/20728#discussion_r172063118 --- Diff: python/pyspark/sql/udf.py --- @@ -42,10 +42,15 @@ def _create_udf(f, returnType, evalType

[GitHub] spark issue #20728: [SPARK-23569][PYTHON] Allow pandas_udf to work with pyth...

2018-03-03 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20728 what should next step be here? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20728: [SPARK-23569][PYTHON] Allow pandas_udf to work with pyth...

2018-03-03 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20728 cc @HyukjinKwon 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20728: [SPARK-23569][PYTHON] Allow pandas_udf to work wi...

2018-03-03 Thread mstewart141
GitHub user mstewart141 opened a pull request: https://github.com/apache/spark/pull/20728 [SPARK-23569][PYTHON] Allow pandas_udf to work with python3 style type-annotated functions ## What changes were proposed in this pull request? Check python version to determine