Github user pepinoflo commented on the issue:
https://github.com/apache/spark/pull/21208
Thanks a lot ueshin, kiszk and mn-mikke for your reviews!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user pepinoflo commented on the issue:
https://github.com/apache/spark/pull/21208
Just changed my email address in those 9 last commits. Unfortunately I
wasn't able to rewrite the first commit as the first merge could not be
preserved even with `git rebase -i -p`. Is that ok
Github user pepinoflo commented on the issue:
https://github.com/apache/spark/pull/21208
Oops, not it's the wrong email address in these commits, I will amend them
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user pepinoflo commented on the issue:
https://github.com/apache/spark/pull/21208
Any idea about the test failure? Test name is
`org.apache.spark.sql.hive.client.HiveClientSuites.(It is not a test it is a
sbt.testing.SuiteSelector)`, and error message
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187816477
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -798,6 +798,156 @@ class DataFrameFunctionsSuite extends
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187816430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class
Github user pepinoflo commented on the issue:
https://github.com/apache/spark/pull/21208
Sorry about the commit history above, I forgot `-p` option during a `git
rebase`.
All my changes are really only in this commit: 471597a.
It includes quite a bit of refactoring
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186292213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r186292037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,140 @@ case class
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185972208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185971775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,132 @@ case class
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185966094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185962048
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958060
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958088
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1229,3 +1229,98 @@ case class Flatten
Github user pepinoflo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r185958014
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -798,6 +798,111 @@ class DataFrameFunctionsSuite extends
GitHub user pepinoflo opened a pull request:
https://github.com/apache/spark/pull/21208
[SPARK-23925][SQL] Add array_repeat collection function
## What changes were proposed in this pull request?
The PR adds a new collection function, array_repeat. As there already
20 matches
Mail list logo
