[GitHub] spark issue #20791: [SPARK-23618][K8s][BUILD] Initialize BUILD_ARGS in docke...

2018-06-29 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/20791 This fix is not showing up in 2.3.1 downloadable. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-18 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @WeichenXu123 resolved merge conflicts. Can you initiate jenkins build? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-15 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 Can you please initiate the Jenkins build? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 I have added to all the algorithms I know that uses intermediate state. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @WeichenXu123 Done the changes to mima. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-08-09 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 There are around 33 binary incompatibility issues as I made this a shared param. Some of them from build logs are below ```scala [error] * abstract synthetic method org$apache$spark$ml

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick i am working on fixes you recommended. Meantime jenkins build doesn't seems to be started. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-24 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick can you start a jenkins build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-24 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 I have updated the code to have the parameter in sharedParamsCodeGen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-16 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick should i go ahead and move it to SharedParamsCodeGen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 Current unit test case is rudimentary. Any help in improving it is appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request #17972: [SPARK-20723][ML]Add intermediate storage level t...

2017-05-13 Thread phatak-dev
GitHub user phatak-dev opened a pull request: https://github.com/apache/spark/pull/17972 [SPARK-20723][ML]Add intermediate storage level to tree based classifiers ## What changes were proposed in this pull request? Currently Random Forest implementation caches

[GitHub] spark issue #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17802 Thanks for the feedback. Updated PR according your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17799: [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable A...

2017-04-28 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17799 Opened new one #17802 with cleaner commit history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17802: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread phatak-dev
GitHub user phatak-dev opened a pull request: https://github.com/apache/spark/pull/17802 [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable API ## What changes were proposed in this pull request? Currently cacheTable API only supports MEMORY_AND_DISK. This PR adds

[GitHub] spark pull request #17799: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread phatak-dev
Github user phatak-dev closed the pull request at: https://github.com/apache/spark/pull/17799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-28 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/16609 @gatorsmile gave pr for the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17799: [SPARK-20495][SQL][CORE]Add StorageLevel to cache...

2017-04-28 Thread phatak-dev
GitHub user phatak-dev opened a pull request: https://github.com/apache/spark/pull/17799 [SPARK-20495][SQL][CORE]Add StorageLevel to cacheTable API ## What changes were proposed in this pull request? Added StorageLevel to cacheTable API ## How was this patch tested

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-27 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/16609 @gatorsmile sure. I will give a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-24 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/16609 cacheTable API doesn't allow user to change the storage level. So having a setName is useful so that we can cache the dataframe in different storage level and still use the UI to identify

[GitHub] spark pull request: [SPARK-7084] improve saveAsTable documentation

2015-04-23 Thread phatak-dev
Github user phatak-dev commented on the pull request: https://github.com/apache/spark/pull/5654#issuecomment-95798250 Added for other methods also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7084] improve saveAsTable documentation

2015-04-23 Thread phatak-dev
GitHub user phatak-dev opened a pull request: https://github.com/apache/spark/pull/5654 [SPARK-7084] improve saveAsTable documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/phatak-dev/spark master Alternatively you

[GitHub] spark pull request: [SPARK-7084] improve saveAsTable documentation

2015-04-23 Thread phatak-dev
Github user phatak-dev commented on the pull request: https://github.com/apache/spark/pull/5654#issuecomment-95522943 Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature