Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @WeichenXu123 @sethah Thanks for your help throughout the process.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick Please find some time to review it and let me know if we can
proceed with this. Thanks
---
-
To unsubscribe, e
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick Thanks for the reviewing the code . Have done changes as
suggested.
Please proceed further if its good to go .
Thanks
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r149886343
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GBTRegressorSuite.scala ---
@@ -166,6 +166,40 @@ class GBTRegressorSuite extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r149886323
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala ---
@@ -173,6 +178,10 @@ object GBTRegressor extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r149886357
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GBTRegressorSuite.scala ---
@@ -166,6 +166,40 @@ class GBTRegressorSuite extends
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
Ping @MLnick @jkbradley . @sethah has given LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @jkbradley Please find some time to review it . @sethah has given
LGTM
---
-
To unsubscribe, e-mail: reviews
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah Build is passed :) ,have done the changes as suggested (setting
maxIter and maxDepth).
ping @MLnick or @jkbradley so we can move ahead
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
Jenkins test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah Its still failing , I don't think so its issue from my side.
Please help
---
-
To unsubscribe, e-mail: reviews
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah Have done the changes as suggested ,but build is failing because of
this error
Step ?Publish JUnit test result report? failed: No test report files were
found. Configuration error
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah please find some time to look into the changes .
Please let me know if further changes are required
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah Thanks for reviewing code . I have done all the changed as
suggested by you .
Please review them and let me know if further changes are required
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197373
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -354,6 +356,41 @@ class GBTClassifierSuite extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197388
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -354,6 +356,41 @@ class GBTClassifierSuite extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197380
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -354,6 +356,41 @@ class GBTClassifierSuite extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197272
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -118,11 +119,12 @@ class DecisionTreeRegressor
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197248
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -192,6 +197,10 @@ object GBTClassifier extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197285
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -118,11 +119,12 @@ class DecisionTreeRegressor
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148197257
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -108,7 +108,8 @@ class DecisionTreeRegressor @Since
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @sethah please find some time to look into this
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @sethah its been more than couple of months since the code changes
has done as suggested. It would be really great if you can find some time to
review it . Please review the pull
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @sethah please find some time to look into this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @sethah please find some time to look into this .It will be really
great if we can include this feature in spark 2.3
---
If your project is set up for it, you can reply to this email
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
ping @MLnick @sethah
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @sethah ,please let me know ,if you are ok with the changes . So
that we can proceed forward . Thanks for your help :)
---
If your project is set up for it, you can reply
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
ping @sethah @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r125484321
--- Diff: project/MimaExcludes.scala ---
@@ -196,7 +196,10 @@ object MimaExcludes {
ProblemFilters.exclude[IncompatibleResultTypeProblem
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r125484168
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GBTRegressorSuite.scala ---
@@ -166,6 +166,45 @@ class GBTRegressorSuite extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r125484140
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -354,6 +356,47 @@ class GBTClassifierSuite extends
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick Thanks for reviewing . Have done all the changes suggested by you .
Please review .
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
ping @sethah @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
ping @sethah , please let me know if there is any update on it . Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah Thanks for comment . Have done the changes as suggested in PR
description.
I'll wait for the review comments from your side :)
---
If your project is set up for it, you can
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123422892
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -192,6 +196,9 @@ object GBTClassifier extends
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick
Thanks for reviewing . I have added comment .
Please review them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123269246
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -359,38 +365,6 @@ private[ml] trait TreeEnsembleParams extends
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah
Thanks for reviewing the pull request .
- Change the title to obey the proper format [SPARK-20199][ML] ...
- Response : Done
- Change title
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123265283
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -192,6 +196,9 @@ object GBTClassifier extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264432
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -136,6 +136,10 @@ class GBTClassifier @Since("
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264336
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -319,8 +327,10 @@ private[spark] object
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264390
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -49,14 +49,16 @@ import org.apache.spark.rdd.RDD
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264302
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -284,11 +290,13 @@ private[spark] object
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264215
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -73,19 +75,21 @@ private[spark] object
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123264263
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -284,11 +290,13 @@ private[spark] object
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@MLnick @srowen
Thanks for your comments , I will wait for someone to review .:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
ping @mpjlu . Please review the pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@sethah agree with you . Sorry if I unnecessary bother , was eager to get
reviews on pull request.
Thanks for the suggestion , will keep in mind
---
If your project is set up for it, you
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@mpjlu
please find some time to review the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
Have done the changes suggested by @mpjlu .
Please find some time to review the pull request .
---
If your project is set up for it, you can reply to this email and have your
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@jkbradley Please review the pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
can any one of admins please review the pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
can any one of admins review the pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
12d83aa is successful . Please review the pull request .
@MLnick @sethah @mpjlu @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@mpjlu : Please review the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
@mpjlu Thanks for reviewing the code . I have done the code changes as
suggested .
Build is passed with all test cases.
Please review and let me know if further changes
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119365434
--- Diff: project/MimaExcludes.scala ---
@@ -37,11 +37,15 @@ object MimaExcludes {
// Exclude rules for 2.3.x
lazy val v23excludes
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364985
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -420,18 +394,18 @@ private[ml] trait RandomForestParams extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119365001
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -441,12 +415,44 @@ private[ml] trait RandomForestParams extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364950
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -305,7 +305,7 @@ private[ml] object TreeRegressorParams
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364792
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -136,12 +136,20 @@ class GBTClassifier @Since("
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364846
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -99,6 +99,8 @@ class DecisionTreeRegressor @Since
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
can any one of admin ,please review the pull request. It would be really
helpful. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
16ccbdf is successful . Please review the pull request .
@MLnick @sethah @mpjlu @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
Can one of the admins please verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pralabhkumar commented on the issue:
https://github.com/apache/spark/pull/18118
[~arushkharbanda][~peng.m...@intel.com][~facai] [~srowen]
Please review the pull request /approach,.
---
If your project is set up for it, you can reply to this email and have your
GitHub user pralabhkumar opened a pull request:
https://github.com/apache/spark/pull/18118
SPARK-20199 : Provided featureSubsetStrategy to GBTClassifier
## What changes were proposed in this pull request?
(Provided featureSubset Strategy to GBTClassifier
a) Moved
68 matches
Mail list logo
