Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199478745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala ---
@@ -34,17 +33,19 @@ private[sql] object PythonSQLUtils
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199498622
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -38,70 +39,75 @@ import org.apache.spark.util.Utils
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199502733
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -398,6 +398,25 @@ private[spark] object PythonRDD extends Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199482134
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -183,34 +182,111 @@ private[sql] object ArrowConverters
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199476976
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -183,34 +182,111 @@ private[sql] object ArrowConverters
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199496002
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3236,13 +3237,50 @@ class Dataset[T] private[sql
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199497456
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -183,34 +182,111 @@ private[sql] object ArrowConverters
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199484323
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3236,13 +3237,50 @@ class Dataset[T] private[sql
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199508609
--- Diff: python/pyspark/serializers.py ---
@@ -184,27 +184,59 @@ def loads(self, obj):
raise NotImplementedError
-class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199482021
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -183,34 +182,111 @@ private[sql] object ArrowConverters
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199499070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -38,70 +39,75 @@ import org.apache.spark.util.Utils
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199371158
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -183,34 +182,111 @@ private[sql] object ArrowConverters
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r199275753
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3236,13 +3237,50 @@ class Dataset[T] private[sql
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20629
+1 for @mgaido91's plan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16722
Yes, feel free to take this over.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user sethah closed the pull request at:
https://github.com/apache/spark/pull/19680
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20701#discussion_r177200509
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala ---
@@ -46,6 +47,10 @@ class KMeansModel @Since("2.4.0") (@Si
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
Merged with master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r171982559
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -703,4 +707,16 @@ private object RandomForestSuite
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
@asolimando I thought of one more thing on the tests that I'd like to have.
Other than that I think this is ready.
@srowen For some reason the tests won't run... Do you have any insight
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r171899289
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -631,10 +634,70 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20709
You don't need to (and should not) open a new PR to fix merge conflicts.
Just fix them through git, on the same branch
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
Jenkins test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20709
Why did you close the old one and re-open this? The discussion is lost now.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20708
* Only committers can trigger the tests.
* MLlib is in maintenance only mode, so we wouldn't accept this patch as
is.
* If this were to go into ML, I think you'd need to discuss it more
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18998#discussion_r171425701
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -93,11 +97,21 @@ class HashingTF @Since("1.4.0") (@Si
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
Jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
Squashing makes it impossible to review the history of the code review, so
I don't think it's a good idea. It's fine for now.
This LGTM. Let's see if @srowen or @jkbradley have any thoughts
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
@asolimando Can you change the title to include `[ML]` and also shorten it.
Maybe just: `Add decision tree pruning
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
@srowen Do we need you to trigger the tests? I'm not sure why they haven't
been run...
---
-
To unsubscribe, e-mail: reviews
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20632
Jenkins test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r171071499
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -266,15 +265,24 @@ private[tree] class LearningNode(
var isLeaf: Boolean
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r171071028
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -92,6 +92,7 @@ private[spark] object RandomForest extends Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r171070831
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -631,10 +634,99 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18998#discussion_r171025256
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -93,11 +97,21 @@ class HashingTF @Since("1.4.0") (@Si
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170738256
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -541,7 +541,9 @@ object DecisionTreeSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170738944
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -631,10 +634,99 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170738068
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -269,12 +268,19 @@ private[tree] class LearningNode(
/**
* Convert
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410905
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -541,7 +541,7 @@ object DecisionTreeSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170412046
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -631,6 +651,160 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410747
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -402,20 +405,40 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410687
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -402,20 +407,35 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410775
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -283,10 +292,12 @@ private[tree] class LearningNode(
// Here we want
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170412098
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -631,6 +651,160 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410851
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -18,17 +18,20 @@
package org.apache.spark.ml.tree.impl
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r170410834
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -270,11 +269,21 @@ private[tree] class LearningNode(
* Convert
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169806418
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -402,20 +405,40 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169834234
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -362,10 +365,10 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169834018
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -359,29 +339,6 @@ class DecisionTreeSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169806576
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -402,20 +405,40 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169833178
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -303,26 +303,6 @@ class DecisionTreeSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169806090
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -402,20 +405,40 @@ class RandomForestSuite extends SparkFunSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169737984
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -287,6 +291,34 @@ private[tree] class LearningNode
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169749740
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -287,6 +291,34 @@ private[tree] class LearningNode
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169735198
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -287,6 +291,34 @@ private[tree] class LearningNode
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169703784
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -287,6 +291,34 @@ private[tree] class LearningNode
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r169391525
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1001,11 +996,18 @@ private[spark] object RandomForest extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20472#discussion_r169386551
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1001,11 +996,18 @@ private[spark] object RandomForest extends
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20472
@srowen Can you trigger the tests?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20332
Thanks a lot for your review, @MLnick!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164476639
--- Diff: docs/ml-classification-regression.md ---
@@ -125,7 +123,8 @@ Continuing the earlier example:
[`LogisticRegressionTrainingSummary`](api/python
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20411
This is already fixed in #20332.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164151869
--- Diff: docs/ml-classification-regression.md ---
@@ -97,10 +97,6 @@ only available on the driver.
[`LogisticRegressionTrainingSummary`](api/scala
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164151796
--- Diff: docs/ml-classification-regression.md ---
@@ -125,7 +117,6 @@ Continuing the earlier example:
[`LogisticRegressionTrainingSummary`](api/python
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164151687
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/MulticlassLogisticRegressionWithElasticNetExample.scala
---
@@ -49,6 +49,48 @@ object
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164151731
--- Diff:
examples/src/main/python/ml/multiclass_logistic_regression_with_elastic_net.py
---
@@ -43,6 +43,43 @@
# Print the coefficients
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20332
@jkbradley @MLnick
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/20332
[SPARK-23138][ML][DOC] Multiclass summary example and user guide
## What changes were proposed in this pull request?
User guide and examples are updated to reflect multiclass logistic
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20188
Thanks, latest commit should fix it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20188
Good call @felixcheung! Will update shortly.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160503466
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160484001
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -1044,6 +1056,50 @@ class LinearRegressionSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160461644
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160503640
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160496808
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160462794
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160502536
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160501723
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160503322
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160471845
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -710,15 +711,57 @@ class LinearRegressionModel private[ml
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160463657
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160483562
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -1044,6 +1056,50 @@ class LinearRegressionSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160461560
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160506592
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -1044,6 +1056,50 @@ class LinearRegressionSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r160463225
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/20188
cc @srowen @holdenk The MLlib counterparts actually make mention of this,
but for some reason the note never got ported over to ML package.
The only caveat I can think of is that this doc
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/20188
[SPARK-22993][ML] Clarify HasCheckpointInterval param doc
## What changes were proposed in this pull request?
Add a note to the `HasCheckpointInterval` parameter doc that clarifies
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r156389238
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r155157785
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -126,15 +180,69 @@ abstract class MLWriter extends BaseReadWrite with
Logging
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r156370588
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
protected
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r156388871
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -994,6 +998,38 @@ class LinearRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19876#discussion_r156381361
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -554,7 +555,49 @@ class LinearRegressionModel private[ml
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19876
@holdenk Do you mind leaving some comments on the intentions/benefits of
this new API for the benefit of other reviewers? For example, what use cases
may exist - adding third party PFA support
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19904#discussion_r155710913
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -146,25 +147,18 @@ class CrossValidator @Since("1.2.0") (@Si
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19904
Can you share your test/results with us?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18729
I actually completely agree about perfect being the enemy of good in this
case. We should provide something workable that can be safely modified in the
future if needed. Still, this needs to be done
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19638#discussion_r149731177
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -764,13 +764,17 @@ class LinearRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19638#discussion_r149559666
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -764,13 +764,17 @@ class LinearRegressionSuite
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19680
I think it's important to restructure these summaries to inherit from the
same traits, so different methods can be re-used. That structure has to live
somewhere and there isn't really a logical
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19680
Mima failures :) These APIs were all marked as experimental, which does
give us some freedom to move them, though I know we prefer to avoid it. It's
mainly complaining that we changed these classes
1 - 100 of 1851 matches
Mail list logo
