Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22381#discussion_r216430755
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -503,9 +503,12 @@ private[spark] object AppStatusStore
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22381#discussion_r216430264
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -280,6 +284,12 @@ private[spark] class AppStatusListener
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22381#discussion_r216429755
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -382,11 +392,37 @@ private[spark] class AppStatusListener
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
> that mirroring of metrics seems like a bigger question
@srowen thanks for the comments, rest api is not always available or a
standard way to export stuff.
This is also the experie
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
please test this
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@felixcheung psl review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/22381
[SPARK-25394][Core] Add application status metrics source
## What changes were proposed in this pull request?
- Exposes several metrics regarding application status as a source
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21398
@vanzin any decision on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r215020138
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -164,7 +164,15 @@ private[spark] class SparkSubmit extends Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r215019733
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,186
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214177723
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214118624
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
---
@@ -0,0 +1,96
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22146
@onursatici we need to test what works and what does not, there are a
number of properties mentioned in the design doc. I would like to see how
things play if you have a full pod spec with many
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22256
Cool @rvesse!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213612518
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
---
@@ -0,0 +1,96
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213612172
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213604900
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213602355
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213600630
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22063#discussion_r213575267
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -164,19 +164,15 @@ abstract class ClassificationModel[FeaturesType
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213047538
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22004
@srowen Lukas has reproduced the TasksErialization issue for the
`FailThisAttempt` object with a minimal program outside Spark. He is going to
investigate further. This has nothing to do
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207877348
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2369,39 +2369,12 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22004
@srowen I was able to reproduce and investigate this further but cleaning
in 2.11 does not seem to affect serialization in this case. I moved the
serialization check at the beginning of the clean
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207868702
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2369,39 +2369,12 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207754816
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2369,39 +2369,12 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207753682
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2369,39 +2369,12 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207752807
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2369,39 +2369,12 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22004#discussion_r207752019
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2583,4 +2556,32 @@ object DAGSchedulerSuite {
def
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
@rxin I will update the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
Sure @lrytz can have a second look on this, also it needs to be battle
tested.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@srowen thanks! So 2.12 will be optional for Spark 2.4? And the major
version for Spark 3.0?
What is the plan
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@srowen gentle ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@srowen I think its ok now. Ready to go.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009415
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -366,14 +423,26 @@ private[spark] object ClosureCleaner extends Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009284
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009194
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009085
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207008830
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207008732
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r206970881
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -107,7 +109,14
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@srowen that is my understanding too and yes they are erased AFAIK, but
just in case I tried it...
---
-
To unsubscribe, e-mail
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@srowen I updated the PR with the minor fixes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@felixcheung I tested with this simple program with Scala 2.11. The app jar
was built against the officially released artifacts (2.3.1):
```
val spark = SparkSession
.builder
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@felixcheung AFAIK as stated (@lrytz) in the doc it shouldnt be. It can be
tested I guess.
---
-
To unsubscribe, e-mail: reviews
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
> `logDebug(s\" + cloning the object $obj of class $`
Is this normal?
---
-
To unsubscribe, e-mail: reviews-
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206562302
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206549150
--- Diff:
core/src/test/scala/org/apache/spark/util/ClosureCleanerSuite2.scala ---
@@ -538,17 +543,22 @@ class ClosureCleanerSuite2 extends SparkFunSuite
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21930
@lrytz @retronym @adriaanm @srowen @felixcheung fyi, pls review.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/21930
[SPARK-14540][Core] Fix remaining major issues for Scala 2.12 Support
## What changes were proposed in this pull request?
This PR addresses issues 2,3 in the
[document](https://docs.google.com
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21924
LGTM. I have the same change locally and it works.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21900
@felixcheung @mccheah this was not fixed.
You need to add this line:
withServiceAccount(kubernetesTestComponents.serviceAccountName)
in the driver's pod spec.
It still fails with User
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21900
Ok I will give it a shot. Sorry kind of missed it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21748#discussion_r205986079
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21748#discussion_r205721972
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
---
@@ -0,0
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@felixcheung can I have a merge pls?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203871861
--- Diff: bin/docker-image-tool.sh ---
@@ -135,7 +135,7 @@ BASEDOCKERFILE=
PYDOCKERFILE=
NOCACHEARG=
BUILD_PARAMS=
-while getopts
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@foxish @srowen I rebased again could you review and merge pls.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21067
@baluchicken yeah I thought of that but I was hoping for more automation.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21067
> Once the partitioned node become available again the unknown old driver
pod got terminated, the volume got unattached and get reattached to the new
driver pod which state now changed from pend
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203313358
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/TestConstants.scala
---
@@ -16,7 +16,7
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@shaneknapp thanks, @srowen @foxish gentle ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203303708
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21800#discussion_r203220877
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -105,9 +102,4 @@ then
properties=( ${properties
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21800#discussion_r203219883
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -105,9 +102,4 @@ then
properties=( ${properties
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203158126
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@shaneknapp what I have done for the issue is modify the build: ` sed -i --
"s@clean package@clean install@g" ./dev/make-distribution.sh` and then run the
build before the suite is run.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203155672
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203101189
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203099369
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@srowen pls review and merge. I updated the description with my local run
and rebased.
---
-
To unsubscribe, e-mail: reviews
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21785
+1 I saw this with my build. I reported on the other PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21542
I see errors when I build lcoally on my machine:
```
[ERROR] Failed to execute goal
com.github.spotbugs:spotbugs-maven-plugin:3.1.3:spotbugs (spotbugs) on project
spark-network
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
thanks @ifilonenko no problem :+1: My only issue was about the snapshot
deps that were not being fetched or something and tests were failing. I still
this in my CI, I checked the dates
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
ok will do :+1:
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
jenkins test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@liyinan926 I had the same issue locally but I dont think it is becaus eof
th ePR.
"[ERROR] Failed to execute goal on project
spark-kubernetes-integration-tests_2.11: Could not re
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21749
@felixcheung sure I will add this to our
https://docs.google.com/document/d/1fbkjEL878witxVQpOCbjlvOvadHtVjYXeB-2mgzDTvk
where we track remaining issues. Scala team already is discussing
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@liyinan926 @srowen pls review or merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r202007781
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -232,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r202007703
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r201685609
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -81,4 +83,35 @@ private[spark] object
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21260
@felixcheung volumes will be supported by the pod template.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201370977
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -232,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201360341
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358932
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201359068
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358773
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358555
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -31,19
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358259
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21260
@felixcheung gentle ping, this is pretty useful.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21067
@baluchicken probably this is covered here:
https://github.com/apache/spark/pull/21260. I kind of missed that, as I thought
it was only for hostpaths but it also covers PVs
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@felixcheung pls review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@foxish @srowen gentle ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21697
@srowen fixed it, ready for final review/merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21697#discussion_r200328768
--- Diff: pom.xml ---
@@ -114,6 +114,7 @@
${java.version}
${java.version}
3.3.9
+2.22.0
--- End diff --
Yes
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21697
@srowen I moved the version to the parent pom. Should I update the version
[here](https://github.com/apache/spark/blob/ca8243f30fc6939ee099a9534e3b811d5c64d2cf/pom.xml#L2125)
too
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@felixcheung I think its ok to merge. In the future when we will add tests
passing more params we can verify it easily, but it is better than before
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@foxish I refactored the tests in different classes. There are some clear
benefits now.
KubernetesSuite should only provide the env setup now
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200136389
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -150,6
101 - 200 of 913 matches
Mail list logo
