Github user ssonker commented on the issue:
https://github.com/apache/spark/pull/21505
I need to update this PR with more changes, will open a new one! Closing
this.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ssonker closed the pull request at:
https://github.com/apache/spark/pull/21505
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ssonker commented on the issue:
https://github.com/apache/spark/pull/21505
@viirya Done.
cc: @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user ssonker commented on the issue:
https://github.com/apache/spark/pull/21505
@kiszk @viirya Do you have more review comments that need to be
incorporated? If not, can you please get this merged
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194319491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194305723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils
Github user ssonker commented on the issue:
https://github.com/apache/spark/pull/21505
@kiszk I've added a benchmark according to your recommendation, please
review.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194294182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -125,7 +125,6 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194292883
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193694372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193686772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193679978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193676953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193675674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193675439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils
GitHub user ssonker opened a pull request:
https://github.com/apache/spark/pull/21505
[SPARK-24457][SQL] Improving performance of stringToTimestamp by cachâ¦
â¦ing Calendar instances for input timezones instead of creating new
everytime
## What changes were proposed
16 matches
Mail list logo
