Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/21006
cc @skonto @samvantran
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20641
@skonto Thanks for testing it. Tests results look good.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20640
I'm in favor of merging this. The hardcoded limit is pretty bad -
particularly for streaming jobs; it would be preferable to remove it ASAP even
though it may not be a complete solution
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/21033
@yanji84 I tried to restore the previous behavior when
`spark.mesos.executor.gpus` is not specified. Here's the commit in my fork:
https://github.com/mesosphere/spark/pull/23/commits
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/21033#discussion_r182283035
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -495,9
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/20641#discussion_r182271196
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -199,6 +199,38
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/21033
LGTM. @yanji84 You may want to remove the "WIP" in the PR title.
---
-
To unsubscribe, e-mail: review
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/21033
@yanji84 Thanks for the patch. I tested your previous PR on GPUs running on
DC/OS and everything worked fine. Would you mind updating the documentation as
well - https://github.com/apache/spark
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20945
(1) seems the most secure. How do we handle keytabs today in cluster mode
in pure Mesos? Is it the same situation -- the keytab gets sent over a HTTP
connection to the Dispatcher?
(3
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20945
@skonto Basic question: in your example above, which user does the
"krb5cc_65534" ticket cache belong to? The superuser or the proxy-user
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/17979
I'm interested in this PR, too. Who has permission to reopen this? cc
@HyukjinKwon @yanji84
---
-
To unsubscribe, e-mail
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20640
@skonto Yes, I'm ok with that. Sorry for the delayed response.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/20641#discussion_r17399
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -199,6 +199,38
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20641
Thanks for the PR! It seems that the previous attempt to fix this
(SPARK-18114) was wrong -- I'm not sure why we didn't catch the problem before,
maybe lack of testing? @krcz My suggestion
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20640
@skonto We should not remove the logging. The logging
[here](https://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/core/src/main/scala/org/apache/spark/scheduler
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/20640#discussion_r169676540
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -648,15
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r166086691
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -71,40 +74,64 @@ trait
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r154991966
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala
---
@@ -77,10 +77,16 @@ private[mesos] class
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r154102830
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153906029
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153824692
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153530156
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153352098
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolRequest.scala
---
@@ -46,6 +46,8 @@ private[rest] class
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153352732
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r150419093
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -122,4 +122,11 @@ package object config
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19543
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r150100634
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -601,10 +602,14
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r150097549
--- Diff: docs/running-on-mesos.md ---
@@ -458,6 +461,14 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r150101873
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -556,7 +556,8 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147429031
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147265329
--- Diff: docs/running-on-mesos.md ---
@@ -613,6 +621,39 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147265261
--- Diff: docs/running-on-mesos.md ---
@@ -613,6 +621,39 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147274681
--- Diff: docs/running-on-mesos.md ---
@@ -344,6 +345,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147277408
--- Diff: docs/running-on-mesos.md ---
@@ -613,6 +621,39 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147265373
--- Diff: docs/running-on-mesos.md ---
@@ -613,6 +621,39 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19510
@windkit Trying to understand the need for this config ... could you
accomplish the same thing by setting spark.cores.max, spark.executor.cores, and
spark.executor.memory? Could you give
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147261741
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r147162791
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r147165029
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +177,88
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r147165077
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +177,88
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r147161356
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r147159788
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146702191
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,78 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146712534
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146712337
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +420,23 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146702357
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,78 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146712170
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -394,9 +393,10 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146704074
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -21,6 +21,39 @@ import
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146712778
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +178,90
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146701899
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,78 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146702275
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,78 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146712893
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +178,90
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@srowen Ping, would you like to help review?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@vanzin Ping, would you mind reviewing this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145530482
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -446,6
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@srowen Would you like to help review? Adding Mesos secrets support in
driver for executor tasks.
---
-
To unsubscribe, e
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145437791
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145437403
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,74 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145437968
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +178,90
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145287767
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145290625
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145290603
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145282997
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145286357
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145268821
--- Diff: docs/running-on-mesos.md ---
@@ -522,6 +522,43 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145282300
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackend.scala
---
@@ -159,7 +160,8
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19374
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@vanzin Would you mind reviewing this PR? A followup to ArtRand's secrets
PR.
---
-
To unsubscribe, e-mail: reviews
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@skonto I haven't tested with TLS; I'll work on that in the next couple of
days.
---
-
To unsubscribe, e-mail: reviews
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143571471
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/Utils.scala
---
@@ -105,4 +108,108 @@ object Utils
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143565549
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143543546
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -21,6 +21,39 @@ import
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143540778
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/Utils.scala
---
@@ -105,4 +108,108 @@ object Utils
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143548722
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,7
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143549493
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143546897
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -17,10 +17,14
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19374
@skonto One more question: in your screen shot of the History Server, I
noticed the "Completed" time is 1969-12-31 for all the drivers (the original
one, retry-1, a
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143344688
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -374,6 +375,15 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143484031
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -804,45 +814,52
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143487275
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143361887
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@ private
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19437
@ArtRand @skonto Please review. Tests passed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user susanxhuynh opened a pull request:
https://github.com/apache/spark/pull/19437
[SPARK-22131][MESOS] Mesos driver secrets
## Background
In #18837 , @ArtRand added Mesos secrets support to the dispatcher. **This
PR is to add the same secrets support to the drivers
Github user susanxhuynh closed the pull request at:
https://github.com/apache/spark/pull/19428
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user susanxhuynh opened a pull request:
https://github.com/apache/spark/pull/19428
[SPARK-22131][MESOS] Mesos driver secrets
## What changes were proposed in this pull request?
The driver launches executors that have access to env or file-based secrets.
Most
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r140117253
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala
---
@@ -63,7 +63,8 @@ class
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r140117055
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -198,16
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r139772286
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala
---
@@ -0,0 +1,150
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r139726573
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala
---
@@ -0,0 +1,150
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r139779444
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -159,6 +159,13 @@ class
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/18910
@srowen Thanks for reviewing. I've removed those spaces; please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/18910
@srowen Sean, would you like to review this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/18910
@vanzin Would you mind helping review this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/18910
@skonto @ArtRand Thanks for the feedback. I have fixed the documentation
and added NETWORK_NAME to the config object. Please let me know what you think.
@skonto I have not tested
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18910#discussion_r132766509
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
---
@@ -582,6
GitHub user susanxhuynh opened a pull request:
https://github.com/apache/spark/pull/18910
[SPARK-21694][MESOS] Support Mesos CNI network labels
JIRA ticket: https://issues.apache.org/jira/browse/SPARK-21694
## What changes were proposed in this pull request?
Spark
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r132008642
--- Diff: docs/running-on-mesos.md ---
@@ -479,6 +479,35 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r132009351
--- Diff: resource-managers/mesos/pom.xml ---
@@ -29,7 +29,7 @@
Spark Project Mesos
mesos
-1.0.0
+1.3.0
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r132040995
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -529,18 +570,120
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r132009978
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -58,12 +58,39 @@ package object config
1 - 100 of 122 matches
Mail list logo
