Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/14441
CCing @srowen, @brkyvz, and @sameeragarwal, who appear to have authored a
good deal of the TimeWindow code, for comment.
---
If your project is set up for it, you can reply to this email and have
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/14441
[SPARK-16837] [SQL] TimeWindow incorrectly drops slideDuration in
constructors
## What changes were proposed in this pull request?
Fix of incorrect arguments (dropping slideDuration
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13861
I had to black out a few hostnames to avoid NDA issues with my clusters,
but the format should be clear.
![updated](https://cloud.githubusercontent.com/assets/1450821/16531866/4f1dca3c-3f83
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13861
Latest commit now uses the more minimalist format discussed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13861
Sorry for the delay, I was away from the computer for a good portion of
yesterday. I'll make the changes that @rxin is suggesting.
To clarify, I am going to do this tweak (changing from
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13861
I'm going to leave the style alone, for the sake of consistency with the
surrounding code.
Anyone else I should ping to get a look at this code?
---
If your project is set up for it, you
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
I opted to force push a cleaned up version, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
Ugh, I just saw that I accidentally merged in some other PRs... I'm a bit
new to this, apologies. Any idea how I can amend this?
---
If your project is set up for it, you can reply to this email
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
My apologies @srowen, I missed the comment somehow! I refactored a little
bit to make it more obvious what's going on there (using `stripPrefix` as you
suggested).
---
If your project is set up
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
CCing some people who were involved in previous commits for this part of
the code, @tdas @zsxwing. Does this look good?
---
If your project is set up for it, you can reply to this email and have
Github user tmagrino commented on a diff in the pull request:
https://github.com/apache/spark/pull/13861#discussion_r68157952
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala
---
@@ -149,6 +150,12 @@ private[ui] class ExecutorTable(stageId: Int
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/13861
[SPARK-15885] [Web UI] Provide links to executor logs from stage details
page in UI
## What changes were proposed in this pull request?
This moves over old PR https://github.com/apache
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13664
I'm going to close this and create a new PR against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tmagrino closed the pull request at:
https://github.com/apache/spark/pull/13664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/13858
[SPARK-16148] [Scheduler] Allow for underscores in TaskLocation in the
Executor ID
## What changes were proposed in this pull request?
Previously, the TaskLocation implementation would
Github user tmagrino closed the pull request at:
https://github.com/apache/spark/pull/13857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13857
Closing this and making a new PR against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/13857
[SPARK-16148] [Scheduler] Allow for underscores in TaskLocation in the
Executor ID
## What changes were proposed in this pull request?
Previously, the TaskLocation implementation would
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13664
Updated images below.
Without logs:
![updated without
logs](https://cloud.githubusercontent.com/assets/1450821/16059721/2b69dbaa-3239-11e6-9eed-e539764ca159.png)
With logs
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/13664
[SPARK-15885] [Web UI] Provide links to executor logs from stage details
page in UI
## What changes were proposed in this pull request?
Added links to logs (or an indication
20 matches
Mail list logo