[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200319604 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200315553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21713 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200125302 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-04 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21713 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200060536 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200053804 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark pull request #21703: [SPARK-24732][SQL] Type coercion between MapTypes...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21703#discussion_r200050957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -179,6 +179,12 @@ object TypeCoercion

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-04 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21713 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-04 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21713 [SPARK-24737][SQL] Type coercion between StructTypes. ## What changes were proposed in this pull request? We can support type coercion between `StructType`s where all the internal types

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200026633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-04 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200024783 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing CaseWhenCoercion rule to handl...

2018-07-04 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21687 Tightening `CaseWhenCoercion` rule should be okay, but I guess we need to fix the output data type of `CaseWhen` and `If` with the same reason as https://github.com/apache/spark/pull/21704

[GitHub] spark pull request #21703: [SPARK-24732][SQL] Type coercion between MapTypes...

2018-07-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21703#discussion_r25967 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -179,6 +179,12 @@ object TypeCoercion

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r19346 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class Concat

[GitHub] spark issue #21704: [SPARK-24734][SQL] Fix containsNull of Concat for array ...

2018-07-03 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21704 @mn-mikke Thanks! I'll take a look and join the discussion later. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21704: [SPARK-24734][SQL] Fix containsNull of Concat for array ...

2018-07-03 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21704 cc @mn-mikke @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-03 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21704 [SPARK-24734][SQL] Fix containsNull of Concat for array type. ## What changes were proposed in this pull request? Currently `Concat` for array type uses the data type of the first child

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-07-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r199722217 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -551,6 +551,36 @@ object TypeCoercion

[GitHub] spark issue #21703: [SPARK-24732][SQL] Type coercion between MapTypes.

2018-07-03 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21703 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21703: [SPARK-24732][SQL] Type coercion between MapTypes...

2018-07-03 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21703 [SPARK-24732][SQL] Type coercion between MapTypes. ## What changes were proposed in this pull request? Currently we don't allow type coercion between maps. We can support type coercion

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

2018-07-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r199384074 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3236,13 +3237,50 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

2018-07-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r199384249 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3236,13 +3237,50 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-07-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r199374528 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -20,6 +20,8 @@ package

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-07-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r199374458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -551,6 +551,36 @@ object TypeCoercion

[GitHub] spark issue #21648: [SPARK-24665][PySpark] Use SQLConf in PySpark to manage ...

2018-07-01 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21648 LGTM for the changes. I'm just wondering if all config types are supported by the PY4J method call. Do we need some tests

[GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt...

2018-06-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21650#discussion_r199051291 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala --- @@ -97,6 +103,64 @@ class

[GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt...

2018-06-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21650#discussion_r199051146 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -166,8 +190,9 @@ object ExtractPythonUDFs extends

[GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt...

2018-06-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21650#discussion_r199048769 --- Diff: python/pyspark/sql/tests.py --- @@ -5060,6 +5049,138 @@ def test_type_annotation(self): df = self.spark.range(1).select(pandas_udf(f

[GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt...

2018-06-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21650#discussion_r199051303 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala --- @@ -97,6 +103,64 @@ class

[GitHub] spark issue #21646: [SPARK-23927][SQL][FOLLOW-UP] Fix a build failure.

2018-06-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21646 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21646: [SPARK-23927][SQL][FOLLOW-UP] Fix a build failure...

2018-06-26 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21646 [SPARK-23927][SQL][FOLLOW-UP] Fix a build failure. ## What changes were proposed in this pull request? This pr is a follow-up pr of #21155. The #21155 removed unnecessary import

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21155 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r198051469 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2289,6 +2292,401 @@ case class Flatten

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21155 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

2018-06-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r198000610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3236,13 +3236,49 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21620: [SPARK-24636][SQL] Type coercion of arrays for ar...

2018-06-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21620#discussion_r197766352 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -536,6 +536,14 @@ object TypeCoercion

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197723939 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2288,6 +2288,401 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197674957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2288,6 +2288,401 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197676498 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2288,6 +2288,401 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197672902 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197670974 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark issue #21630: [SPARK-23931][SQL][FOLLOW-UP] Make `arrays_zip` in funct...

2018-06-24 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21630 cc @DylanGuedes @HyukjinKwon @viirya @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21630: [SPARK-23931][SQL][FOLLOW-UP] Make `arrays_zip` i...

2018-06-24 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/21630 [SPARK-23931][SQL][FOLLOW-UP] Make `arrays_zip` in function.scala `@scala.annotation.varargs`. ## What changes were proposed in this pull request? This is a follow-up pr of #21045 which

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197666356 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197665988 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197666062 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197666362 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197666255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-24 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197665954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -475,6 +474,231 @@ case class MapEntries

[GitHub] spark issue #21282: [SPARK-23934][SQL] Adding map_from_entries function

2018-06-22 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21282 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21282: [SPARK-23934][SQL] Adding map_from_entries function

2018-06-22 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21282 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197063803 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -80,6 +80,138 @@ class

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197053302 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197063520 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -80,6 +80,138 @@ class

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197064670 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -633,6 +633,51 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197054805 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197065983 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197056077 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197069050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197059371 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

2018-06-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r197061444 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -474,6 +473,221 @@ case class MapEntries

[GitHub] spark issue #21581: [SPARK-24574][SQL] array_contains, array_position, array...

2018-06-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21581 But the emails of commits in this pr seem not valid, just for the local computer. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197004678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197001921 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197005444 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197003678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197004881 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197005083 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197004822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197004944 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r197004467 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,347 @@ case class

[GitHub] spark issue #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21050 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21581: [SPARK-24574][SQL] array_contains, array_position, array...

2018-06-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21581 @chongguang I think this pr is ready to merge, so I tried, but seems like the commits in this pr aren't connected with your GitHub account. If you want to connect the merge commit to your account

[GitHub] spark issue #21581: [SPARK-24574][SQL] array_contains, array_position, array...

2018-06-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21581 LGTM pending tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21581: [SPARK-24574][SQL] array_contains, array_position, array...

2018-06-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21581 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196707308 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r196662595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2355,297 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r196654369 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,281 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r196654348 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,281 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r196654935 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,281 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r196654756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,281 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r196654969 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,281 @@ case class

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196633968 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -571,6 +571,10 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196633908 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21567 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195855869 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195855829 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195859919 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195859752 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195859393 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195861358 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195857889 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195856243 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195859728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195856511 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195859900 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195855296 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195856376 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2355,3 +2356,319 @@ case class

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

2018-06-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195854348 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2376,112 +2376,297 @@ case class

<    1   2   3   4   5   6   7   8   9   10   >