[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r195854421 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2376,112 +2376,297 @@ case class

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r195852498 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3236,13 +3236,49 @@ class Dataset[T] private[sql

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r195822151 --- Diff: python/pyspark/serializers.py --- @@ -184,27 +184,31 @@ def loads(self, obj): raise NotImplementedError -class

[GitHub] spark pull request #21546: [WIP][SPARK-23030][SQL][PYTHON] Use Arrow stream ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21546#discussion_r195824174 --- Diff: python/pyspark/sql/dataframe.py --- @@ -2153,7 +2153,7 @@ def _collectAsArrow(self): """ with SCCallSi

[GitHub] spark issue #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21258 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21045: [SPARK-23931][SQL] Adds arrays_zip function to sparksql

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21045 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194527119 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194516045 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194523480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194530787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520589 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194520120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r194517152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,293 @@ case class

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r194514576 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -186,6 +186,50 @@ class ComplexTypeSuite

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r194514611 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -186,6 +186,50 @@ class ComplexTypeSuite

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r194501372 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,170 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r194208465 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python] Enable grouped aggregate pand...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21082 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21282: [SPARK-23934][SQL] Adding map_from_entries functi...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21282#discussion_r193958595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +309,234 @@ case class MapEntries

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r193929635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -236,6 +236,76 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r193929951 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -236,6 +236,76 @@ case class CreateMap

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193928034 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193928619 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926575 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193927174 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926459 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193926035 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193927263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193899743 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r193895158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1468,3 +1472,388 @@ case class Flatten

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r193841141 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1883,134 @@ case class

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r193837080 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r193826690 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +308,170 @@ case class MapEntries

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r193236096 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192921149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192920012 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192920586 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192920690 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192919335 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,302 @@ case class

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r192919160 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +308,170 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r192918429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -116,6 +117,161 @@ case class MapValues

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r192918533 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +308,170 @@ case class MapEntries

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r192918569 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +308,170 @@ case class MapEntries

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192868913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,176 @@ case class MapKeys

[GitHub] spark pull request #21282: [SPARK-23934][SQL] Adding map_from_entries functi...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21282#discussion_r192861844 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -308,6 +309,234 @@ case class MapEntries

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192855626 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -315,6 +316,91 @@ class

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192854400 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192852173 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192853351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192849961 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192849800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192851368 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192856581 --- Diff: python/pyspark/sql/functions.py --- @@ -2394,6 +2394,23 @@ def array_repeat(col, count): return Column(sc._jvm.functions.array_repeat

[GitHub] spark pull request #21045: [SPARK-23931][SQL] Adds zip function to sparksql

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21045#discussion_r192850510 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -128,6 +128,175 @@ case class MapKeys

[GitHub] spark issue #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21479 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192536919 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -186,6 +186,50 @@ class ComplexTypeSuite

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192535551 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192535592 --- Diff: python/pyspark/sql/functions.py --- @@ -1798,6 +1798,22 @@ def create_map(*cols): return Column(jc

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192536842 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21258: [SPARK-23933][SQL] Add map_from_arrays function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21258#discussion_r192535941 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -235,6 +235,86 @@ case class CreateMap

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1206,6 +1206,41 @@ class AstBuilder(conf: SQLConf

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534446 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -739,6 +740,7 @@ nonReserved | VIEW | REPLACE

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1206,6 +1206,41 @@ class AstBuilder(conf: SQLConf

[GitHub] spark pull request #21282: [SPARK-23934][SQL] Adding map_from_entries functi...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21282#discussion_r192531374 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -118,6 +120,229 @@ case class MapValues

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192520463 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2189,3 +2189,302 @@ case class

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192516776 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -592,6 +592,7 @@ primaryExpression | identifier

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192479966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark issue #21479: [SPARK-23903][SQL] Add support for date extract

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21479 What about day_of_week? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21069: [SPARK-23920][SQL]add array_remove to remove all element...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21069 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r192291498 --- Diff: python/pyspark/sql/dataframe.py --- @@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False): else

[GitHub] spark issue #21069: [SPARK-23920][SQL]add array_remove to remove all element...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21069 LGTM pending Jenkins. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21386: [SPARK-23928][SQL][WIP] Add shuffle collection function.

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21386 @pkuwm Btw, if you want to implement some algorithm like "Fisher-Yates algorithm" by hand, please add a comment near the code, and a link you referred

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192254481 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192252991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192250043 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192251150 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192253086 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192249752 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192254166 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192250954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r192251238 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,311 @@ case class

[GitHub] spark issue #21386: [SPARK-23928][SQL][WIP] Add shuffle collection function.

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21386 Thanks for your contribution! You can refer `Uuid` and its test as I mentioned in a comment. Could you update this? I'll revisit when you push new commits

[GitHub] spark pull request #21386: [SPARK-23928][SQL][WIP] Add shuffle collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21386#discussion_r192224235 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -555,6 +557,100 @@ case class ArraySort

[GitHub] spark pull request #21386: [SPARK-23928][SQL][WIP] Add shuffle collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21386#discussion_r192214008 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -555,6 +557,100 @@ case class ArraySort

[GitHub] spark pull request #21386: [SPARK-23928][SQL][WIP] Add shuffle collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21386#discussion_r192213797 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -31,6 +32,7 @@ import

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r192209239 --- Diff: python/pyspark/sql/dataframe.py --- @@ -351,8 +352,62 @@ def show(self, n=20, truncate=True, vertical=False): else

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r192207299 --- Diff: python/pyspark/sql/dataframe.py --- @@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False): else

[GitHub] spark issue #21010: [SPARK-23900][SQL] format_number support user specifed f...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21010 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21010: [SPARK-23900][SQL] format_number support user specifed f...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21010 LGTM pending Jenkins. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21010: [SPARK-23900][SQL] format_number support user specifed f...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21010 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21010: [SPARK-23900][SQL] format_number support user specifed f...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21010 Thanks, sounds good. Let me retrigger the build just for checking again. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21010: [SPARK-23900][SQL] format_number support user specifed f...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21010 Basically LGTM, but I'm wondering what if the `expr2` is not like a format string? --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r191956713 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,117 @@ case class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r191955752 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,117 @@ case class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r191955459 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1882,3 +1882,117 @@ case class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r191958470 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -552,4 +552,60 @@ class

[GitHub] spark issue #21362: [SPARK-24197][SparkR][FOLLOWUP] Fixing failing tests for...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21362 @mn-mikke Actually, yes. But unfortunately I'm not familiar with R and the environment I heard about it, so I'm not able to figure out the reason for now

[GitHub] spark issue #21362: [SPARK-24197][SparkR][FOLLOWUP] Fixing failing tests for...

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21362 Hi, any updates on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21246: [SPARK-23901][SQL] Add masking functions

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21246 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

<    2   3   4   5   6   7   8   9   10   11   >