Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21040
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185197041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185196808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21054#discussion_r185170928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
---
@@ -23,23 +23,13 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21054#discussion_r185170552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
---
@@ -62,14 +52,6 @@ case class Average(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21054#discussion_r185171846
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/regression.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166848
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21040
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r184914154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -378,6 +378,138 @@ case class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21121
I'm not sure we really need this function.
If the purpose is only for `transform` function you mentionsed at
https://github.com/apache/spark/pull/21121#issuecomment-383319312, how about
adding
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r184310311
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184293071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -185,6 +183,8 @@ trait ArraySortUtil
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21011
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r184266872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,18 @@ case class MapValues
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -300,6 +333,49 @@ case class Reverse
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262545
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -168,9 +140,9 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -168,9 +140,9 @@ case class SortArray
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,18 @@ case class MapValues
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -300,6 +333,49 @@ case class Reverse
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21008
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r184257279
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -105,4 +105,28 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r184257274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20938
I'm sorry for the delay.
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20938
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r183011714
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -169,4 +169,45 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182999463
--- Diff: python/pyspark/sql/functions.py ---
@@ -2168,6 +2171,23 @@ def sort_array(col, asc=True):
return Column(sc._jvm.functions.sort_array
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182992892
--- Diff: python/pyspark/sql/functions.py ---
@@ -2154,10 +2154,13 @@ def array_max(col):
def sort_array(col, asc=True
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r18236
--- Diff: python/pyspark/sql/functions.py ---
@@ -2154,10 +2154,13 @@ def array_max(col):
def sort_array(col, asc=True
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182998415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +117,18 @@ case class MapValues
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182993016
--- Diff: python/pyspark/sql/functions.py ---
@@ -2168,6 +2171,23 @@ def sort_array(col, asc=True):
return Column(sc._jvm.functions.sort_array
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182990028
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -169,4 +169,45 @@ class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20938
LGTM pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182973891
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -169,4 +169,45 @@ class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20858
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20938
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21053
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182703273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182706982
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -102,6 +102,12 @@ trait
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182701319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182701643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182701040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182702693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,101 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21040#discussion_r182705280
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -105,4 +105,28 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r182682158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r182688229
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r182689303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r182686266
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -106,6 +106,30 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r182680902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -288,6 +288,114 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182672237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -505,3 +506,150 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182671380
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -169,4 +169,45 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182663898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -505,3 +506,150 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r182674039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +418,156 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21008#discussion_r182625943
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -870,24 +870,14 @@ object DateTimeUtils
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21008#discussion_r182625871
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -453,34 +453,45 @@ class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21037
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21094
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21034
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r182362454
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,28 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20858
LGTM except for nits.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r182350135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -353,3 +356,218 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r182349064
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -353,3 +356,218 @@ case class ArrayMax
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20938
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21011#discussion_r182333814
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,27 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r182325781
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +417,106 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r182327230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +417,106 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r182326476
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,28 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r182323290
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,28 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21094
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21037#discussion_r182298375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -353,3 +353,61 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21037#discussion_r182297896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -353,3 +353,61 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21037#discussion_r182298195
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -353,3 +353,61 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21037#discussion_r182316985
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -18,6 +18,7 @@
package
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21037#discussion_r182297625
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,23 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21094
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/21094
[SPARK-24007][SQL] EqualNullSafe for FloatType and DoubleType might
generate a wrong result by codegen.
## What changes were proposed in this pull request?
`EqualNullSafe` for `FloatType
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r182024316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +419,179 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r182018964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +419,179 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r182026581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +419,179 @@ case class ArrayMax
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r182024380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -417,3 +419,179 @@ case class ArrayMax
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21025
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21034
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r181640349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +290,231 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r181638570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +290,231 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r181643397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +290,231 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r181641673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +290,231 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r181639154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +290,231 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r181623803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,106 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r181619426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,106 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r181618055
--- Diff: python/pyspark/sql/functions.py ---
@@ -1846,6 +1846,27 @@ def array_contains(col, value):
return Column(sc._jvm.functions.array_contains
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r181617303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
---
@@ -354,3 +336,37 @@ case class GetMapValue
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21053#discussion_r181619450
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,106 @@ case class
901 - 1000 of 2567 matches
Mail list logo
