Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22569
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22569
cc @dongjoon-hyun @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22569
[SPARK-25542][SQL][Test] Move flaky test in OpenHashMapSuite to
OpenHashSetSuite
## What changes were proposed in this pull request?
The specified test in OpenHashMapSuite to test large
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22556
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220765052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,25 @@ object TypeCoercion
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220460094
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -257,12 +257,48 @@ class TypeCoercionSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220459877
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -257,12 +257,48 @@ class TypeCoercionSuite
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22544
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
Oh, I see. May the code template make some confusion. I'd change it. The
downstream code is wrapped inside an if block. I don't clearly show how
downstream operators work in codegen. Let me update
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r220409552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ---
@@ -167,6 +170,56 @@ package object util
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
hmm, in above suggested way, isn't `setStopEarly(true)` called when
consuming `given_limit` + 1 records? Otherwise I may misunderstand
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220244473
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220241139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class ElementAt
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
Doesn't this way consume one more record than given limit number?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r220195279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ---
@@ -167,6 +170,56 @@ package object util
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220193922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class ElementAt
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220140660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220140252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220147139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22544
@dilipbiswal The two examples shown in the PR description are allowed in
current and this proposes to disallow them? I'm a bit confused by the
description
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220054697
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -71,22 +71,14 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
> It will be great to explain how limit works in whole stage codegen, in
general. This part is a little hard to understand and I believe many operators
need to deal with limit as well.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220048264
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -71,22 +71,14 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220046213
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -73,14 +78,21 @@ public void append(InternalRow row
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220046092
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -73,14 +78,21 @@ public void append(InternalRow row
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220044740
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -71,22 +71,14 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220044584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -465,13 +465,18 @@ case class RangeExec(range
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r220040370
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -38,6 +38,11 @@
protected int partitionIndex
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22535
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r219731695
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -556,7 +556,7 @@ class DataFrameAggregateSuite extends QueryTest
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
@xuanyuanking Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
> Does this means you got a Reason: Error during SSL Handshake with remote
server after open the jenkins link?
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r219690825
--- Diff: R/pkg/R/functions.R ---
@@ -3404,19 +3404,27 @@ setMethod("collect_set",
#' Equivalent to \code{split} SQL function.
#'
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r219691017
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2546,15 +2546,39 @@ object functions {
def soundex(e: Column): Column
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r219690753
--- Diff: R/pkg/R/functions.R ---
@@ -3404,19 +3404,27 @@ setMethod("collect_set",
#' Equivalent to \code{split} SQL function.
#'
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22524
Is jenkins down now?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r219690438
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -84,9 +84,10 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22524#discussion_r219690413
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -465,13 +465,18 @@ case class RangeExec(range
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22524
[SPARK-25497][SQL] Limit operation within whole stage codegen should not
consume all the inputs
## What changes were proposed in this pull request?
This issue was discovered during https
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
cc @cloud-fan @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219410274
--- Diff: R/pkg/R/DataFrame.R ---
@@ -226,7 +226,8 @@ setMethod("showDF",
#' show
#'
-#' Print class and type information
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22455
Let's also update the doc of `REPL_EAGER_EVAL_ENABLED` in `SQLConf`. After
this patch, eager evaluation is not only supported in PySpark
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219404319
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22514
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22514
[SPARK-25271][SQL] Hive ctas commands should use data source if it is
convertible
## What changes were proposed in this pull request?
We have a
[regression](https://github.com/apache
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219351707
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219348795
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219347786
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22479
Thanks @HyukjinKwon. LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22479#discussion_r219053623
--- Diff: python/pyspark/sql/tests.py ---
@@ -1168,7 +1168,7 @@ def test_simple_udt_in_df(self):
df = self.spark.createDataFrame
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/22464
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22481
Revert [SPARK-19355][SPARK-25352]
## What changes were proposed in this pull request?
This goes to revert sequential PRs based on some discussion and comments at
https://github.com/apache
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22481
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
@cloud-fan Shall we have 4 PRs to revert these PRs individually?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
@cloud-fan Ok. Let me try it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22465#discussion_r218998728
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1561,6 +1561,13 @@ object SQLConf {
"are perf
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
Thanks @HyukjinKwon @maropu. I've put it in the PR description.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
cc @cloud-fan @rxin @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22464
Revert [SPARK-19355][SPARK-25352]
## What changes were proposed in this pull request?
This goes to revert
[SPARK-19355](https://github.com/apache/spark/pull/16677) and
[SPARK-25352](https
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
I understood the two major concerns regarding this change. I'm going to
submit a pr to revert the change. I will look into this idea further with new
design
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22456#discussion_r218685917
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -31,7 +31,7 @@ import org.apache.spark.util.Utils
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218652707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218639550
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218639483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
I'm not sure where it can cause perf regressions. Basically this just
changes the way we retrieve records from partitions when performing limit. This
doesn't do shuffling them together to single
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r218638143
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -98,7 +98,8 @@ case class LocalLimitExec(limit: Int, child: SparkPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r218631953
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -98,7 +98,8 @@ case class LocalLimitExec(limit: Int, child: SparkPlan
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
@rxin Thanks for the comment. I will improve the document in a pr.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r218631052
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -98,7 +98,8 @@ case class LocalLimitExec(limit: Int, child: SparkPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r218630241
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -98,7 +98,8 @@ case class LocalLimitExec(limit: Int, child: SparkPlan
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22344
Thanks @rxin. I will submit a pr to improve the readability.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r218627396
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -98,7 +98,8 @@ case class LocalLimitExec(limit: Int, child: SparkPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22440#discussion_r218021130
--- Diff: docs/sql-programming-guide.md ---
@@ -1879,6 +1879,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21217
@mgaido91 No problem. Please submit the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21217
Thanks @jamesthomp for you work. When we pick this up, I think we can still
give the credit of the work to you
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r217995920
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -402,13 +402,13 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r218000227
--- Diff: docs/sql-programming-guide.md ---
@@ -1877,6 +1877,10 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r218003046
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -450,7 +450,7 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r218000572
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -595,10 +607,7 @@ case class JsonToStructs
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217981686
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -143,16 +143,14 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r217915212
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala
---
@@ -16,11 +16,33 @@
*/
package
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22417
LGTM too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22395
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217747363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -314,6 +314,32 @@ case class Divide(left
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217631634
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -314,6 +314,27 @@ case class Divide(left
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22417#discussion_r217619116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -59,6 +59,6 @@ abstract
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21217
@HyukjinKwon thanks for pinging me. I'd wait for others to take over this
first, if no one does, I can do it later
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r217433074
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,8 @@ trait
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22409
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22409
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22409
cc @hvanhovell @dbtsai @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22409
[SPARK-25352][SQL][Followup] Add helper method and address style issue
## What changes were proposed in this pull request?
This patch address [the review
comment](https://github.com/apache
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20521#discussion_r217255531
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -56,34 +57,36 @@ case class
501 - 600 of 9955 matches
Mail list logo
