Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22246#discussion_r213164929
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -124,6 +141,26 @@ class SparkILoop(in0: Option[BufferedReader], out
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22162
We should wait @AndrewKL for few days?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212928747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,22 @@ case class JsonToStructs
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
@hvanhovell ah, updated. also updated the PR description too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
@maropu Thanks. I just added it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212856674
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3237,6 +3237,20 @@ class Dataset[T] private[sql](
files.toSet.toArray
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212854255
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3237,6 +3237,20 @@ class Dataset[T] private[sql](
files.toSet.toArray
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212856186
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -289,6 +289,14 @@ private
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212854351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -329,49 +329,52 @@ abstract class SparkPlan extends QueryPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212854113
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -329,49 +329,52 @@ abstract class SparkPlan extends QueryPlan
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
Sure, thank you @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212847031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,22 @@ case class JsonToStructs
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
@hvanhovell I can set `spark.sql.limit.flatGlobalLimit` to false to match
`TakeOrderedAndProjectExec` semantics at the beginning of
`TakeOrderedAndProjectSuite`. Or you prefer to add an explicit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
> @viirya did you try to run TakeOrderedAndProjectSuite? I am pretty sure
that will fail now ;)...
Not yet. Let me
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22239
[SPARK-19355][SQL][Followup] Remove the child.outputPartitioning check
## What changes were proposed in this pull request?
This is based on the discussion
https://github.com/apache/spark
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r212844439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22234#discussion_r212825429
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -345,11 +345,11 @@ def text(self, paths, wholetext=False, lineSep=None):
@since(2.0)
def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r212812744
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1022,116 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r212812771
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -44,7 +45,12 @@ private[parquet] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r212812718
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1022,116 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r212812673
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -350,25 +356,38 @@ private[parquet] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r212812755
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1022,116 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r212811618
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r212792753
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-limit.sql
---
@@ -1,6 +1,9 @@
-- A test suite for IN LIMIT in parent
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r212783356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -232,30 +232,41 @@ case class RLike(left
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r212783481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -232,30 +232,41 @@ case class RLike(left
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r212783375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -232,30 +232,41 @@ case class RLike(left
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/9
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22171
> How can this happen? When Spark writes decimal out, the external systems
will get decimal values, not string values.
I have the same quest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21732#discussion_r212520685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -19,25 +19,85 @@ package
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
@cloud-fan I made attempt to remove `topLevel` parameter. The approach is
to flatten serializers and deserialzer at `TypedAggregateExpression`. So users
are not aware of difference when using
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22206#discussion_r212497182
--- Diff: python/pyspark/sql/tests.py ---
@@ -6394,6 +6394,17 @@ def test_invalid_args(self):
df.withColumn('mean_v', mean_udf(df['v
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22206#discussion_r212496291
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -130,10 +133,22 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22206#discussion_r212488758
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -130,10 +133,22 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22206#discussion_r212488439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -130,10 +133,22 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22206#discussion_r212484229
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -130,10 +133,22 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22157#discussion_r212475271
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -79,9 +79,10 @@ object OrcUtils extends Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22157#discussion_r212304433
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -562,20 +562,57 @@ abstract class OrcQueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22171#discussion_r212289525
--- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out ---
@@ -197,7 +197,7 @@ select .e3
-- !query 20
select 1E309, -1E309
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22171#discussion_r212244913
--- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out ---
@@ -197,7 +197,7 @@ select .e3
-- !query 20
select 1E309, -1E309
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22157#discussion_r212229343
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -79,9 +79,10 @@ object OrcUtils extends Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22157#discussion_r212225224
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -562,20 +562,57 @@ abstract class OrcQueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22157#discussion_r212223394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -79,9 +79,10 @@ object OrcUtils extends Logging
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22187
+1 LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22171#discussion_r212165658
--- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out ---
@@ -197,7 +197,7 @@ select .e3
-- !query 20
select 1E309, -1E309
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22171#discussion_r212165521
--- Diff:
sql/core/src/test/resources/sql-tests/results/higher-order-functions.sql.out ---
@@ -201,6 +201,7 @@ struct<>
-- !query 20
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22187
Yeah, I agreed with @rednaxelafx to directly ship the StructType objects
looks like a better solution. +1
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22181
cc @zsxwing @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22181
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22171
So this is an issue only related to `Dataset.show`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22182
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16478
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22181
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16478
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22181
[SPARK-25163][SQL] Fix flaky test:
o.a.s.util.collection.ExternalAppendOnlyMapSuiteCheck
## What changes were proposed in this pull request?
`ExternalAppendOnlyMapSuiteCheck` test is flaky
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21859
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22152
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16478
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
This is not urgent, but if you have time, can you help review this? @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/19756
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16478
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22168#discussion_r211619140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -1058,31 +1064,37 @@ private class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22168#discussion_r211607297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -975,8 +979,10 @@ private class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22168#discussion_r211609440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -1028,23 +1034,23 @@ private class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22152#discussion_r211599957
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
---
@@ -69,10 +70,17 @@ private[sql] object JsonInferSchema
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22024
@vincent-grosbois I don't look into this change yet. Do you have reply for
@dbtsai's comment
https://github.com/apache/spark/pull/22024#issuecomment-412659532
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22024
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211506399
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22154
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22154
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21859
If this optimization is done more generally, will the implicitly cached
data cause memory pressure on driver, as seems we don't have way to release
them
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22163
What you mean `only one record is written to a buffer each time`? Isn't it
controlled by `diskWriteBufferSize` to write such size of data each time
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22154
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211446570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211443168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211443069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -63,7 +49,10 @@ abstract
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211432763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -63,7 +49,10 @@ abstract
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22151
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22151#discussion_r211246362
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -201,13 +201,11 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22151#discussion_r211246064
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala
---
@@ -179,7 +192,7 @@ class AvroLogicalTypeSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22151#discussion_r211243540
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -201,13 +201,11 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
> if we can totally hide the topLevel parameter from users, it should be
fine. Generally I think the behavior is consistent, now Option[Product] is
always a struct type column. But we n
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22152#discussion_r211189624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
---
@@ -69,10 +70,17 @@ private[sql] object JsonInferSchema
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22150
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22150
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21859
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r211122674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1207,6 +1207,13 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r211122076
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -155,6 +156,8 @@ class RangePartitioner[K : Ordering : ClassTag, V
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089742
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21931
Minor comments. LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089705
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1437,6 +1437,16 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089716
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20232
Thanks @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20232
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20232
ping @dbtsai do you have time to review this too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
From the above, I think the aggregator encoder for `Option[Product]` might
be a bit tricky to use for users, since they might need to know the difference
between `topLevel = true` and `topLevel
701 - 800 of 9955 matches
Mail list logo
