[GitHub] spark issue #16648: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-03-09 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/16648 @bdrillard Is there a particular reason why this patch hasn't been looked at yet? I think you should CC some of the authors of the code you have changed to speed things up. --- If your project

[GitHub] spark pull request #17012: [SPARK-19677][SS] Renaming a file atop an existin...

2017-02-27 Thread vitillo
Github user vitillo commented on a diff in the pull request: https://github.com/apache/spark/pull/17012#discussion_r103219157 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -274,6 +274,11 @@ private[state

[GitHub] spark issue #17012: [SPARK-19677][SS] Renaming a file atop an existing one s...

2017-02-23 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/17012 @zsxwing I have rewritten the test code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17012: [SPARK-19677][SS] Renaming a file atop an existing one s...

2017-02-22 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/17012 @zsxwing The test is there just to make sure the new code path is executed during tests; should I remove it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17012: [SPARK-19677][SS] Renaming a file atop an existing one s...

2017-02-21 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/17012 @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17012: [SPARK-19677][SS] Renaming a file atop an existin...

2017-02-21 Thread vitillo
GitHub user vitillo opened a pull request: https://github.com/apache/spark/pull/17012 [SPARK-19677][SS] Renaming a file atop an existing one should not fail on HDFS ## What changes were proposed in this pull request? HDFSBackedStateStoreProvider fails to rename files

[GitHub] spark pull request #16857: [SPARK-19517][SS] KafkaSource fails to initialize...

2017-02-17 Thread vitillo
Github user vitillo commented on a diff in the pull request: https://github.com/apache/spark/pull/16857#discussion_r101803033 --- Diff: external/kafka-0-10-sql/src/test/resources/kafka-source-initial-offset-version-2.1.0.bin --- @@ -0,0 +1 @@ +2{"kafka-initial-offset-

[GitHub] spark issue #16857: [SPARK-19517][SS] KafkaSource fails to initialize partit...

2017-02-15 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/16857 @zsxwing I updated the PR as per proposal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16857: [SPARK-19517][SS] KafkaSource fails to initialize partit...

2017-02-10 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/16857 @uncleGen I have added a new unit test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16857: [SPARK-19517][SS] KafkaSource fails to initialize partit...

2017-02-08 Thread vitillo
Github user vitillo commented on the issue: https://github.com/apache/spark/pull/16857 @zsxwing Since I can't access the build results you could please tell me why the patch fails to build? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #16857: [SPARK-19517][SS] KafkaSource fails to initialize...

2017-02-08 Thread vitillo
GitHub user vitillo opened a pull request: https://github.com/apache/spark/pull/16857 [SPARK-19517][SS] KafkaSource fails to initialize partition offsets ## What changes were proposed in this pull request? This patch fixes a bug in `KafkaSource` with the (de)serialization