GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17721
[SPARK-20013][SQL]merge renameTable to alterTable in ExternalCatalog
## What changes were proposed in this pull request?
merge renameTable to alterTable in ExternalCatalog has some
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17354
late LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
@gatorsmile sbt test succeed, and mvn `create temporary view using` passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
mvn, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
test sbt, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
add #17290 again, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
@gatorsmile I have merge this pr with master and revert #17290, and
waiting for the jenkins to test
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
ok, let me do it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
@gatorsmile we can find all the test failed here [maven test
result](https://spark-tests.appspot.com/builds/spark-master-test-maven-hadoop-2.7/2799)
---
If your project is set up for it, you can
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17344
LGTMï¼but why maven test has this problemï¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17341
cc @cloud-fan @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
yes,it is.
It (jar:file://) will be re-resolved by new Path later, and will throw an
exception described in the jira.
---
If your project is set up for it, you can reply to this email
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17341#discussion_r106782193
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -732,40 +696,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17341#discussion_r106782178
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,30 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17341#discussion_r106782179
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,30 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17341#discussion_r106782161
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,30 +196,6 @@ abstract class
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17341
[SPARK-20013][SQL]add a newTablePath parameter for renameTable in
ExternalCatalog
## What changes were proposed in this pull request?
Currently when we create / rename a managed table
Github user windpiger closed the pull request at:
https://github.com/apache/spark/pull/17340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780117
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -732,40 +676,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780097
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,50 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780090
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,50 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780038
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,50 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780033
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,50 +196,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780030
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -196,50 +196,6 @@ abstract class
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17340
[SPARK-20013][SQL] merge renameTable to alterTable in ExternCatalog
## What changes were proposed in this pull request?
## How was this patch tested?
delete some tests
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
According to the jenkins' log, the test case ` test("create temporary view
using")` in `DDLSuite` passed the test.
This pr resolved the test failed reported in
[SPARK-19
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r106778719
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17338
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17338#discussion_r106777091
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -700,20 +701,33 @@ abstract class DDLSuite extends
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17338
[SPARK-19990][SQL]create a temp file for file in test.jar's resource when
run test accross different modules
## What changes were proposed in this pull request?
After we have merged
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106570185
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -27,41 +27,67 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106569991
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -27,41 +27,67 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106569958
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -27,41 +27,67 @@ import
Github user windpiger closed the pull request at:
https://github.com/apache/spark/pull/17317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17317
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17317
[SPARK-19329][SQL][BRANCH-2.1]Reading from or writing to a datasource table
with a non pre-existing location should succeed
## What changes were proposed in this pull request
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16672
ok thanksï¼its my pleasureï½
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17287
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106342082
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -1270,6 +1376,7 @@ class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106336735
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -76,468 +102,500 @@ class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106336045
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -999,257 +1083,279 @@ class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106335967
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -1270,6 +1376,7 @@ class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106335778
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -999,257 +1083,279 @@ class
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17287
@gatorsmile @cloud-fan I have fix some code view, could you help to
continue reivew this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17305
yesï¼it is a trivial jiraï½
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17305
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17305
[SPARK-19961][SQL][minor]unify a erro msg when drop databse for
HiveExternalCatalog and InMemoryCatalog
## What changes were proposed in this pull request?
unify a exception erro
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106145746
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -27,41 +27,83 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r106065119
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -76,468 +118,499 @@ class
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17272
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17272#discussion_r105889902
--- Diff: python/pyspark/sql/tests.py ---
@@ -1892,7 +1892,7 @@ def test_list_tables(self):
self.assertEquals(spark.catalog.listTables
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r105860834
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -999,257 +1094,279 @@ class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17287#discussion_r105858890
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -27,41 +27,83 @@ import
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17287
[SPARK-19945][SQL]add test suite for SessionCatalog with HiveExternalCatalog
## What changes were proposed in this pull request?
Currently `SessionCatalogSuite` is only
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17272
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17272#discussion_r105834140
--- Diff: python/pyspark/sql/tests.py ---
@@ -1901,7 +1901,7 @@ def test_list_tables(self):
self.assertEquals(len(tables), 2
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17272
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17272
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17272#discussion_r105601636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -155,6 +154,8 @@ case class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17272#discussion_r105601455
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -164,15 +164,6 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17272#discussion_r105601271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -187,38 +187,32 @@ class InMemoryCatalog
Github user windpiger closed the pull request at:
https://github.com/apache/spark/pull/17057
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17272
[SPARK-19724][SQL]create a managed table with an existed default table
should throw an exception
## What changes were proposed in this pull request?
This JIRA is a follow up work after
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/15918
this change of `schemaFor` will affect the default behavior.
For example:
[udf in
functions.scala](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17001
@gatorsmile thanks for your suggestion~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17211#discussion_r105576214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -167,599 +153,6 @@ case class DescribeDatabaseCommand
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17254
cc @cloud-fan @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17254
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17055#discussion_r105526116
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2016,48 +2016,79 @@ abstract class DDLSuite extends
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17254#discussion_r105526016
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2180,6 +2181,13 @@ abstract class DDLSuite extends
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17254#discussion_r105526010
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1357,13 +1360,11 @@ abstract class DDLSuite extends
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17254#discussion_r105526000
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1201,7 +1202,9 @@ abstract class DDLSuite extends
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17254
[SPARK-19917][SQL]qualified partition path stored in catalog
## What changes were proposed in this pull request?
partition path should be qualified to store in catalog
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17055#discussion_r105520260
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1663,95 +1663,127 @@ class HiveDDLSuite
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17055#discussion_r105519542
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2016,48 +2016,79 @@ abstract class DDLSuite extends
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17055
OK thanks a lotï½
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17055
@gatorsmile I have merged with masterï¼if it is ok, could you help to
merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17095
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16592#discussion_r105111257
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -306,6 +306,11 @@ private[sql] trait SQLTestUtils
val fs
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16592
greate~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17211
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17211
[SPARK-19869][SQL]move table related ddl from ddl.scala to tables.scala
## What changes were proposed in this pull request?
move table related ddl from ddl.scala to tables.scala
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17055
@gatorsmile this pr could be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17204
[SPARK-19864][SQL]provide a makeQualifiedPath functions to optimize some
code
## What changes were proposed in this pull request?
Currently there are lots of places to make
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17001
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17176#discussion_r104660965
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -159,36 +159,11 @@ class HadoopTableReader(
def
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17187#discussion_r104643185
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -170,6 +169,40 @@ object HiveAnalysis extends Rule[LogicalPlan
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17176
why jenkins failed...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17097#discussion_r104570109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -88,46 +90,81 @@ class CacheManager extends Logging
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17176
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17176#discussion_r104400143
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -159,36 +159,37 @@ class HadoopTableReader(
def
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17176
[SPARK-19833][SQL]remove SQLConf.HIVE_VERIFY_PARTITION_PATH, always return
empty when the location does not exists
## What changes were proposed in this pull request?
In SPARK-5068, we
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17173
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104361311
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104361050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
---
@@ -162,6 +164,28 @@ object CatalogUtils
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359591
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358279
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -883,7 +885,7 @@ abstract class
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17173
[SPARK-19832][SQL]DynamicPartitionWriteTask get partitionPath should escape
the partition name
## What changes were proposed in this pull request?
Currently in DynamicPartitionWriteTask
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104309883
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1596,147 @@ class HiveDDLSuite
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r104285450
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
1 - 100 of 455 matches
Mail list logo
