Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/12147
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/12147
I will re-open this PR once I resolve the issue. Thanks! @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/12147
@HyukjinKwon My rebased branch has broken most of the window exclude test
cases. Trying to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/12147
Since there are a lot of changes by other PRs over the last year, many
changes in this PR may not be applicable and I am doing the rebase and
necessary rework on this PR. Will update soon
Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/13687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/13687
Closed since the hive refactoring code has resolve this issue by the way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/13687
Let me rebase and code and try again . Will close it if we don't have any
issue. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r121593031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -262,19 +270,55 @@ object
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r121592843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1825,6 +1847,18 @@ class Analyzer
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r121592724
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -631,6 +631,17 @@ frameBound
| expression boundType
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
@cloud-fan @gatorsmile Thanks again! I updated the code based @cloud-fan 's
review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107053921
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2178,4 +2178,138 @@ abstract class DDLSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107051682
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1860,4 +1861,115 @@ class HiveDDLSuite
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107051308
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2178,4 +2178,138 @@ abstract class DDLSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107050116
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -965,9 +965,27 @@ class JDBCSuite extends SparkFunSuite
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107050148
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/TableScanSuite.scala ---
@@ -416,4 +416,22 @@ class TableScanSuite extends DataSourceTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107049979
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2178,4 +2178,138 @@ abstract class DDLSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107049953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -296,6 +311,51 @@ class SessionCatalog
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106790141
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1860,4 +1861,119 @@ class HiveDDLSuite
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106765877
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -296,6 +297,45 @@ class SessionCatalog
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106682311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -175,6 +178,98 @@ case class AlterTableRenameCommand
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106682210
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -450,6 +451,26 @@ abstract class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106682149
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -450,6 +451,26 @@ abstract class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r106344896
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -71,7 +71,6 @@ class JDBCSuite extends SparkFunSuite
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
@gatorsmile @cloud-fan In order to use `ExternalCatalog.alterTableSchema`
API, I need to add `SessionCatalog.alterTableSchema` that calls
`ExternalCatalog.alterTableSchema`. Please check
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r105289122
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -504,94 +504,57 @@ private[spark] class HiveExternalCatalog
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
@gatorsmile yes. I will do so. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16592
@gatorsmile is this PR going to be merged soon, since the ALTER ADD column
PR #16626 also depends on this to create test cases for InMemoryCatalog. Thanks!
---
If your project is set up
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r103024279
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -563,35 +574,47 @@ private[spark] class HiveExternalCatalog
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
@gatorsmile Thanks for your comments! I will update the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r10070
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -187,15 +187,18 @@ class CSVSuite extends QueryTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100697250
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1690,6 +1690,16 @@ class DDLSuite extends QueryTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100697200
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -213,27 +216,33 @@ class CSVSuite extends QueryTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100697245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100697216
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -187,15 +187,18 @@ class CSVSuite extends QueryTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100697194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -187,15 +187,18 @@ class CSVSuite extends QueryTest
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100647313
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100646859
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100646267
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100642343
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16878
@gatorsmile @cloud-fan Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/16878
[SPARK-19539][SQL] Block duplicate temp table during creation
## What changes were proposed in this pull request?
Current `CREATE TEMPORARY TABLE ... ` is deprecated and recommend users to
use
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99681895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99681470
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99681098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99679239
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99679185
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -763,7 +763,9 @@ object DDLUtils {
val HIVE_PROVIDER
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99660704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r99660453
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +816,50 @@ object DDLUtils
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16156
https://issues.apache.org/jira/browse/SPARK-19409 is resolved to upgrade to
parquet-1.8.2 that fixes this issue.
---
If your project is set up for it, you can reply to this email and have your
Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/16156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/13300
@HyukjinKwon Thanks! After your #16680 is merged, submit a PR with the code
you show above. then.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/13300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16685
@ilganeli Thanks for replying to my comments! Please correct me if I am
wrong. My understanding of your assumption is that the target table does not
have or maintain any unique constraints. Mostly
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16685
A few comments:
1. The mayor concern is that this solution need to pull in the whole target
table data and do a join operation between the source dataframe and the target
table
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97213829
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -168,6 +168,43 @@ case class AlterTableRenameCommand
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97213702
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -584,14 +593,18 @@ private[spark] class HiveExternalCatalog
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97213578
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -107,7 +107,13 @@ public
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97191587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -168,6 +168,43 @@ case class AlterTableRenameCommand
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97191366
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -814,4 +814,28 @@ object DDLUtils
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16626
@gatorsmile @cloud-fan Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16617
@stanzhai I submitted another PR to this JIRA, since I already have the
code that handles a few more aspects that I mentioned in my PR.
---
If your project is set up for it, you can reply
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/16626
[SPARK-19261][SQL] Alter add columns for Hive tables
## What changes were proposed in this pull request?
Support ALTER TABLE ADD COLUMNS (...) syntax for Hive tables.
In this PR, we
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16156
For normal parquet reader case, we have the following code
```Scala
} else {
logDebug(s"Falling back to parquet-mr")
// ParquetRecordReader returns
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16156
@liancheng I see. In normal parquet reader, ParquetFileFormat is using
hadoop's `ParquetRecordReader`, which we can not add such toleration code.
---
If your project is set up for it, you can
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16156#discussion_r90970607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -578,4 +578,66 @@ class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16156#discussion_r90969322
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -578,4 +578,66 @@ class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16156#discussion_r90968718
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -578,4 +578,66 @@ class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16156#discussion_r90968659
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -578,4 +578,66 @@ class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16156#discussion_r90968586
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -107,7 +107,16 @@ public
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16156
@gatorsmile @liancheng Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/16156
[SPARK-18539][SQL]: tolerate pushed-down filter on non-existing parquet
columns
## What changes were proposed in this pull request?
When `spark.sql.parquet.filterPushdown
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/13300
@maropu Thanks for the comments! It seems like adding such new datasource
API in DataFrameReader is not in the priority now. That is why it has been in
relatively idle state now. What you
Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/15107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15123#discussion_r79274396
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -325,6 +325,24 @@ class DataFrameSuite extends QueryTest
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/15107
@hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/15107
[SPARK-17551][SQL] complete the NULL ordering support in DataFrame APIs
## What changes were proposed in this pull request?
This PR is to complete the feature - NULLS FIRST | LAST in sorting
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@hvanhovell @ericl Please see if anything else I miss. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@ericl Thanks so much for the detailed review and suggestions. I will fix
the last comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
Retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78271045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,22 +40,56 @@ object SortPrefixUtils {
def
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,33 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78268705
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78268093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267758
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -27,14 +27,45 @@
public class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78265625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77372825
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77283504
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77281310
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77227594
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226997
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226868
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226814
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,49 +100,161 @@ public static long computePrefix
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221980
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
sortItem
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221335
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
sortItem
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77200539
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends
1 - 100 of 309 matches
Mail list logo
