Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12066
@holdenk Sorry for late response, I'm really busy recently. Sure, I'll
close this now. Feel free to take over it. Thanks
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/12066
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21494#discussion_r194172809
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -123,6 +124,21 @@ private[spark] class TaskSetManager
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21494#discussion_r194176991
--- Diff:
core/src/main/scala/org/apache/spark/barrier/BarrierCoordinator.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/21249
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20459#discussion_r165239367
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -93,7 +93,7 @@ private[feature] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20459#discussion_r165189663
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -93,7 +93,7 @@ private[feature] trait
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/20459
[SPARK-23107][ML] ML 2.3 QA: New Scala APIs, docs.
## What changes were proposed in this pull request?
Audit new APIs and docs in 2.3.0.
## How was this patch tested?
No test
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19156
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19994
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r158138431
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/SummarizerSuite.scala ---
@@ -35,237 +34,252 @@ class SummarizerSuite extends SparkFunSuite
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17146
@Antoinelypro Sorry for late response. Actually we have default value if
users don't set _link_ explicitly. Could you show the detail of your error
case? Thanks
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/19994
[SPARK-22810][ML][PySpark] Expose Python API for LinearRegression with
huber loss.
## What changes were proposed in this pull request?
Expose Python API for _LinearRegression_ with _huber_
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
Merged into master, thanks for all your reviewing.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r156856635
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -480,10 +640,14 @@ object LinearRegression extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r156564056
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/SummarizerSuite.scala ---
@@ -205,67 +207,21 @@ class SummarizerSuite extends SparkFunSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r156564200
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/SummarizerSuite.scala ---
@@ -19,149 +19,165 @@ package org.apache.spark.ml.stat
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19958
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19958
cc @WeichenXu123 @jkbradley
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/19958
[SPARK-21087] [ML] [FOLLOWUP] Sync SharedParamsCodeGen and sharedParams.
## What changes were proposed in this pull request?
#19208 modified ```sharedParams.scala```, but didn't generated
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r156517313
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -197,14 +240,14 @@ private[ml] object SummaryBuilderImpl extends Logging
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19793
@vanzin It seems this PR breaks [Jenkins
test](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84790/console),
could you help to resolve it? Also cc @gatorsmile @cloud-fan
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19525
Merged into master and branch-2.2. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19676#discussion_r155913190
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java ---
@@ -51,9 +52,17 @@ public static void main(String[] args
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19676
It's good to have this, sorry for late response, I will make a pass
tomorrow. Thanks.
---
-
To unsubscribe, e-mail: reviews
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r155413347
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -122,17 +124,33 @@ private[ml] object Param {
/** Decodes
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r155411609
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/linalg/JsonMatrixConverter.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r155412287
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -122,17 +124,33 @@ private[ml] object Param {
/** Decodes
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r155414284
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -476,6 +476,10 @@ class DenseMatrix @Since("2.0.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r155414954
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2769,6 +2769,20 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r149823481
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -197,14 +240,14 @@ private[ml] object SummaryBuilderImpl extends Logging
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19156#discussion_r149764998
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -94,46 +97,86 @@ object Summarizer extends Logging {
* - min
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19648
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149522834
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -827,6 +831,11 @@ class SparseMatrix @Since("2.0.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149533876
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2769,6 +2769,20 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149522660
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -476,6 +476,10 @@ class DenseMatrix @Since("2.0.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149530436
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/linalg/JsonMatrixConverter.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149532602
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/linalg/JsonMatrixConverter.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149534129
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2769,6 +2769,20 @@ class
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19525
Will make a pass soon.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19156
I'd like to make a pass soon.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
@hhbyyh I have compared this implementation with sklearn
```HuberRegressor``` on several dataset listed at
https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/regression.html, they
can
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149251282
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -998,6 +1047,198 @@ class LinearRegressionSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149251168
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -480,10 +638,14 @@ object LinearRegression extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149250515
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149250222
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -344,33 +449,58 @@ class LinearRegression @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247649
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247683
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -142,6 +221,9 @@ class LinearRegression @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247570
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247543
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247240
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -208,6 +292,26 @@ class LinearRegression @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247162
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -744,11 +754,20 @@ object LinearRegressionModel extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r149247042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19648#discussion_r148861446
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala
---
@@ -22,15 +22,21 @@ import
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19648
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@jkbradley @mgaido91 I just sent #19648 to move test data to data/mllib,
please feel free to review it. Thanks
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/19648
[SPARK-14516][ML][FOLLOW-UP] Move ClusteringEvaluatorSuite test data to
data/mllib.
## What changes were proposed in this pull request?
Move ```ClusteringEvaluatorSuite``` test data(iris
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 Don't worry, I'll post a follow-up PR for discussion in a few
days. Thanks.
---
-
To unsubscribe, e-mail: reviews
GitHub user yanboliang reopened a pull request:
https://github.com/apache/spark/pull/19020
[SPARK-3181] [ML] Implement huber loss for LinearRegression.
## What changes were proposed in this pull request?
MLlib ```LinearRegression``` supports _huber_ loss addition
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/19020
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16548
@holdenk Could you let me know where we meet similar issue in the
fulltests? AFAIK, we test functions in ```e1071``` only when it was installed
on that node, like following
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
@sethah To the issue that whether huber linear regression share codebase
with ```LinearRegression```, we have discussion at
[JIRA](https://issues.apache.org/jira/browse/SPARK-3181). At last
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19020
@jkbradley Thanks for your comments, I have addressed all your inline
comments. Please see replies to your other questions below:
> Echoing @WeichenXu123 's comment: Why use "
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140440076
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -998,6 +1047,172 @@ class LinearRegressionSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140439435
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -220,12 +283,12 @@ class LinearRegression @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140439369
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -69,19 +69,57 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140439119
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140439171
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -69,19 +69,57 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r140439140
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19204
Merged into master, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139718610
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,77 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19156
@WeichenXu123 Sorry for late response, really busy in these days. I will
take a look in a few days. Thanks for your patience
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19262
Merged into master. Thanks for reviewing.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139312695
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,86 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/19262
[MINOR][ML] Remove unnecessary default value setting for evaluators.
## What changes were proposed in this pull request?
Remove unnecessary default value setting for all evaluators, as we
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139312388
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,86 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139312199
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,86 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139312034
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,86 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19204#discussion_r139312046
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -328,6 +329,86 @@ def setParams(self, predictionCol="prediction",
labelCol="label",
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19220
Merged into master, thanks for all reviewing.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138792851
--- Diff: python/pyspark/ml/tests.py ---
@@ -1464,20 +1464,79 @@ def test_logistic_regression_summary(self):
self.assertEqual
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19220
cc @zhengruifeng @jkbradley @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18902
Merged into master. Thanks for all.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/19220
[SPARK-18608][ML][FOLLOWUP] Fix double caching for PySpark OneVsRest.
## What changes were proposed in this pull request?
#19197 fixed double caching for MLlib algorithms, but missed PySpark
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 I opened
[SPARK-21981](https://issues.apache.org/jira/browse/SPARK-21981) for Python
API, would you like to work on it? Thanks
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
I'm merging this into master, thanks for all. If anyone has more comments,
we can address them in follow-up PRs
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/19185
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 These are my last comments, it should be ready to merge once they
are addressed. Thanks for your contribution
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255937
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138256035
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255648
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18538#discussion_r138255474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138047555
--- Diff: python/pyspark/ml/tests.py ---
@@ -1478,6 +1478,40 @@ def test_logistic_regression_summary(self):
sameSummary = model.evaluate(df
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138048004
--- Diff: python/pyspark/ml/tests.py ---
@@ -1478,6 +1478,40 @@ def test_logistic_regression_summary(self):
sameSummary = model.evaluate(df
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138046547
--- Diff: python/pyspark/ml/classification.py ---
@@ -603,6 +614,112 @@ def featuresCol(self):
"""
return
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138047016
--- Diff: python/pyspark/ml/classification.py ---
@@ -603,6 +614,112 @@ def featuresCol(self):
"""
return
1 - 100 of 2641 matches
Mail list logo
