Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275764
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,48 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275714
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275722
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275721
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275712
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275697
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164275706
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164260027
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -160,6 +187,11 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on the issue:
https://github.com/apache/spark/pull/20367
@srowen It seems that this PR needs Admin approval. Could you please help
getting it to the next step? Thanks
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163465302
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -119,6 +119,41 @@ class CountVectorizerSuite extends
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163359719
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -113,7 +132,11 @@ private[feature] trait CountVectorizerParams
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163358962
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -119,6 +119,41 @@ class CountVectorizerSuite extends
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163358747
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -169,7 +201,7 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on the issue:
https://github.com/apache/spark/pull/20367
@mgaido91 I closed the previous PR and opened this one.
I am answering your comments here.
---
-
To unsubscribe, e-mail
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20366#discussion_r163355218
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -119,6 +119,41 @@ class CountVectorizerSuite extends
Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20366#discussion_r163355088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -169,7 +197,7 @@ class CountVectorizer @Since("1.5.0"
Github user ymazari commented on the issue:
https://github.com/apache/spark/pull/20367
@hhbyyh, @MLnick, @jkbradley could you please help reviewing this? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user ymazari opened a pull request:
https://github.com/apache/spark/pull/20367
[SPARK-23166][ML] Add maxDF Parameter to CountVectorizer
## What changes were proposed in this pull request?
Currently, the CountVectorizer has a minDF parameter.
It might be useful
Github user ymazari closed the pull request at:
https://github.com/apache/spark/pull/20366
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user ymazari opened a pull request:
https://github.com/apache/spark/pull/20366
[SPARK-23166] [ML] Add maxDF Parameter to CountVectorizer
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch
20 matches
Mail list logo
