[GitHub] spark pull request #19170: [SPARK-21961][Core] Filter out BlockStatuses Accu...

2018-08-02 Thread zhouyejoe
Github user zhouyejoe closed the pull request at: https://github.com/apache/spark/pull/19170 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20744: [SPARK-23608][CORE][WebUI] Add synchronization in SHS be...

2018-03-15 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/20744 It is weird that the PySpark unit tests failed, I don't think it is related. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #20744: [SPARK-23608][CORE][WebUI] Add synchronization in...

2018-03-14 Thread zhouyejoe
Github user zhouyejoe commented on a diff in the pull request: https://github.com/apache/spark/pull/20744#discussion_r174548913 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -150,14 +150,18 @@ class HistoryServer( ui: SparkUI

[GitHub] spark pull request #20744: [SPARK-23608][CORE][WebUI] Add synchronization in...

2018-03-12 Thread zhouyejoe
Github user zhouyejoe commented on a diff in the pull request: https://github.com/apache/spark/pull/20744#discussion_r173981826 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -148,14 +148,17 @@ class HistoryServer( appId: String

[GitHub] spark issue #20744: [SPARK-23608][CORE][WebUI] Add synchronization in SHS be...

2018-03-08 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/20744 Updated. Please help trigger the jenkins again. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20744: [SPARK-23608][CORE][WebUI] Add synchronization in...

2018-03-06 Thread zhouyejoe
Github user zhouyejoe commented on a diff in the pull request: https://github.com/apache/spark/pull/20744#discussion_r172609731 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -148,14 +148,14 @@ class HistoryServer( appId: String

[GitHub] spark pull request #20744: [SPARK-23608][CORE][WebUI] Add synchronization in...

2018-03-05 Thread zhouyejoe
GitHub user zhouyejoe opened a pull request: https://github.com/apache/spark/pull/20744 [SPARK-23608][CORE][WebUI] Add synchronization in SHS between attachSparkUI and detachSparkUI functions to avoid concurrent modification issue to Jetty Handlers Jetty handlers are dynamically

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-12-12 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 @vanzin Yes, I agree with you that the latest listener will not write these data into logs. But here is the story. We deployed SHS(Spark History Server) with LevelDB months ago in our clusters

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-12-11 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 @vanzin The problem still exists with your new changes to Spark History Server. Once you use ListenerBus to replay the log(https://github.com/apache/spark/blob/master/core/src/main/scala/org

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-12-11 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 Hi, @vanzin. No, this doesn't change anything else. It only changes how the JSON data gets transferred into Events. I was a little bit busy with other stuffs. I will fix the unit test

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-11-15 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 I will work on it. Thanks for review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-11-06 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 @jiangxb1987 Hi, I was waiting for the response from Ryan Blue about the ticket SPARK-20084. The fix for the unit test should be pretty straight forward. I just need a confirmation

[GitHub] spark issue #17412: [SPARK-20084][Core] Remove internal.metrics.updatedBlock...

2017-09-20 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/17412 @rdblue Hi, why not the blockstatusupdates are not filtering out in executorMetricsUpdate? This line https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util

[GitHub] spark issue #19170: [SPARK-21961][Core] Filter out BlockStatuses Accumulator...

2017-09-20 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/19170 I will fix the unit test failure. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #19170: [SPARK-21961][Core] Filter out BlockStatuses Accu...

2017-09-08 Thread zhouyejoe
GitHub user zhouyejoe opened a pull request: https://github.com/apache/spark/pull/19170 [SPARK-21961][Core] Filter out BlockStatuses Accumulators during replaying history logs in Spark History Server ## What changes were proposed in this pull request? Filter out

[GitHub] spark pull request #18941: [SPARK-21715][WebUI] History Server should not re...

2017-09-07 Thread zhouyejoe
Github user zhouyejoe closed the pull request at: https://github.com/apache/spark/pull/18941 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18941: [SPARK-21715][WebUI] History Server should not re...

2017-08-22 Thread zhouyejoe
Github user zhouyejoe commented on a diff in the pull request: https://github.com/apache/spark/pull/18941#discussion_r134587276 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -161,6 +161,7 @@ private[spark] object UIUtils extends Logging { def

[GitHub] spark pull request #18941: [SPARK-21715][WebUI] History Server should not re...

2017-08-22 Thread zhouyejoe
Github user zhouyejoe commented on a diff in the pull request: https://github.com/apache/spark/pull/18941#discussion_r134579481 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -161,6 +161,7 @@ private[spark] object UIUtils extends Logging { def

[GitHub] spark pull request #18941: [SPARK-21715][CORE] History Server should not res...

2017-08-14 Thread zhouyejoe
GitHub user zhouyejoe opened a pull request: https://github.com/apache/spark/pull/18941 [SPARK-21715][CORE] History Server should not respond history page html conte… ## What changes were proposed in this pull request? Add the images required by dataTables jQuery plugin