[GitHub] spark issue #21693: [SPARK-24673][SQL] scala sql function from_utc_timestamp...

2018-07-05 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/21693 @HyukjinKwon will this pr be merged into branch-2.3/branch-2.2 too? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21609: [SPARK-22897][CORE] Expose stageAttemptId in TaskContext

2018-06-21 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/21609 Can this pr be merged ASAP? Currently there is an error on branch-2.2 . --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21577: [SPARK-24589][core] Correctly identify tasks in output c...

2018-06-21 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/21577 @vanzin @tgravescs , after merge this pr into branch-2.2, there is an error "stageAttemptNumber is not a member of org.apache.spark.TaskContext" in SparkHadoopMapRedUtil, I think it need

[GitHub] spark issue #16964: [SPARK-19534][TESTS] Convert Java tests to use lambdas, ...

2017-11-10 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/16964 @dahaian I think this is the issue of Eclipse, you can open 'JavaConsumerStrategySuite.java' file, remove the '.mapValues' and then retype '.mapValues' again, save file to recompile

[GitHub] spark issue #18470: [SPARK-21258][SQL] Fix WindowExec complex object aggrega...

2017-06-30 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/18470 Hi, @cloud-fan , @hvanhovell , after merging this pr into **branch-2.1**, there are some errors: 1. `value WINDOW_EXEC_BUFFER_SPILL_THRESHOLD is not a member of object

[GitHub] spark issue #17008: [SPARK-19669][HOTFIX][SQL] sessionState access privilege...

2017-02-20 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/17008 I meet the same error in branch master : **overriding lazy value sessionState in class SparkSession of type org.apache.spark.sql.internal.SessionState; lazy value sessionState has weaker access

[GitHub] spark issue #16964: [SPARK-19534][TESTS] Convert Java tests to use lambdas, ...

2017-02-16 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/16964 @srowen after update to master, in Eclipse IDE, there is an error in JavaConsumerStrategySuite.java line 52: `final Map<TopicPartition, Long> offsets = new HashMap<>();

[GitHub] spark issue #16146: [SPARK-18091] [SQL] [BACKPORT-1.6] Deep if expressions c...

2017-02-14 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/16146 ping @cloud-fan , will this pr be merged into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-14 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 It sounds good. @zsxwing could you take a look at this pr? does this pr plan to be merged into branch-2.1? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-01 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 ping @aramesh117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-09-12 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 @aramesh117 you should update code based on master branch to resovlve conflicts, and then, jenkins will test this pr automatically. --- If your project is set up for it, you can reply

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-09-12 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 ping @zsxwing @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-09-05 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 @aramesh117 @zsxwing @tdas Is there any process at this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14390: [SPARK-15541] Casting ConcurrentHashMap to ConcurrentMap...

2016-08-04 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/14390 @maver1ck I think you need to open another pr for change in Catalog.scala. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14420: [SPARK-14204] [SQL] register driverClass rather than use...

2016-08-01 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/14420 @JoshRosen can you have a look at this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14420: [SPARK-14204] [SQL] register driverClass rather than use...

2016-07-31 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/14420 @srowen will this pr be meged into branch-2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #12000: [SPARK-14204] [SQL] register driverClass rather than use...

2016-07-30 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12000 thanks, @mchalek --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #12000: [SPARK-14204] [SQL] register driverClass rather than use...

2016-07-30 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12000 @srowen @mchalek could you open a new pr for master/branch-2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #12000: [SPARK-14204] [SQL] register driverClass rather than use...

2016-07-29 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12000 Hi, @srowen @JoshRosen @mchalek , this issue still exists on branch-2.0/master, if I add "driver=com.mysql.jdbc.Driver" property to write.jdbc's properties params, it was ok, otherw

[GitHub] spark issue #12000: [SPARK-14204] [SQL] register driverClass rather than use...

2016-07-27 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12000 @srowen @JoshRosen does this pr need to be merged into master or branch-2.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark issue #13196: [SPARK-15395][Core]Use getHostString to create RpcAddres...

2016-06-19 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13196 @zsxwing , why does this pr be reverted in branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13630: Revert "Incorrectly merged AFTAggregator with zero total...

2016-06-14 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13630 ping @mengxr @yanboliang @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-13 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13619 @HyukjinKwon , just see it, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-13 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13619 @HyukjinKwon , could you revert this pr for branch-1.6 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-12 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13619 @HyukjinKwon OK, but this pr should be reverted first. @jkbradley could you revert this pr for branch-1.6 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732911 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732825 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732808 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark issue #12105: [SPARK-14321][SQL] Reduce date format cost and string-to...

2016-06-02 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12105 @rajeshbalamohan , Is there any progress yet? We meet the same performance issues when formatting date or operating string-to-date . --- If your project is set up for it, you can reply

[GitHub] spark issue #12000: [SPARK-14204] [SQL] register driverClass rather than use...

2016-06-01 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/12000 @srowen @JoshRosen @holdenk could you take a look and merge this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-29 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-222398286 ping @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-221769197 @JoshRosen , could you merge this into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...

2016-05-19 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220470402 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...

2016-05-18 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220218127 ï¼ zsxwing will this pr be merged into branch 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Sh...

2016-05-18 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13027#issuecomment-220040626 @davies , could you review this pr and merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-16 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-219626090 @mchalek @JoshRosen Is there any progress yet? I got the same error with spark-1.6.1. But if I add "driver=com.mysql.jdbc.Driver" property to write.jdbc's

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

2016-05-12 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-218947787 @markhamstra , thanks for your explaintion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

2016-05-12 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-218942375 Good PR, will it plan to be merged into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Sh...

2016-05-11 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13027#issuecomment-218647036 ping @davies @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Sh...

2016-05-11 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13027#issuecomment-218381595 This pr is great for us, solved some ExecutorLost problems for branch-1.6. this includes the commit PR #13020 for the branch-1.6 version too? --- If your project

[GitHub] spark pull request: [SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Sh...

2016-05-11 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13027#issuecomment-218378667 This PR includes the commit PR #13020 for the branch-1.6 version too. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-05 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-217320918 @srowen , add below code twice into branch 1.6: `if (successful(index)) {` ` logInfo(` `s"Task ${info.id} in stage ${taskSet.id} (TID

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2016-04-21 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10024#issuecomment-212790206 sorry, I mistakenly deleted my comment. what a pity, i can only merge this pr manually. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

2016-04-21 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10024#issuecomment-212781140 @davies , will this pr be backported to branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-04-11 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-208654680 @davies , but I didn't find this commit in branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-04-11 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-208604888 @davies has this pr cherry-picked into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13431] [SQL] [test-maven] split keyword...

2016-02-23 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/11331#issuecomment-18851 @davies , cool, i build with maven successfully according to this pr, The maven command I have used: mvn clean package -DskipTests -Pscala-2.11 -Phadoop-2.6 -Phive

[GitHub] spark pull request: [Spark-12260][wip][Streaming]Graceful Shutdown...

2016-02-15 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10252#issuecomment-184515856 @chenghao-intel @mwws , sorry for my late reply. Currently, we just record the kafka offset and accumulators to third-party storage system after per batch

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-02-02 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/10608#discussion_r51677442 --- Diff: pom.xml --- @@ -165,7 +165,7 @@ 3.2.2 2.10.5 --- End diff -- @JoshRosen , why this version is 2.10.5

[GitHub] spark pull request: [Spark-12260][wip][Streaming]Graceful Shutdown...

2016-01-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10252#issuecomment-174453565 Hi, @mwws , @chenghao-intel , is there any progress on this pr? When we use spark streaming, it will lose some stateful data when we upgrade code, i think this pr

[GitHub] spark pull request: [DOC]fix 'spark.memory.offHeap.enabled' defaul...

2016-01-06 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10633#issuecomment-169571829 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-10 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/10265#issuecomment-163853516 Hi, @yucai , my code is executed successfully with this pr. It's great. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-03 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-161676006 @hvanhovell , thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-02 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-161240681 @hvanhovell , is there any progress? will this pr be merged into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-02 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-161494736 @hvanhovell , thanks for your replying. Currently, there are some window statistical reports in our requirement, but without hive environment. Will this pr be merged

[GitHub] spark pull request: [SPARK-7173][YARN] Add label expression suppor...

2015-11-18 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/9800#issuecomment-157918712 It's cool. Will this pr merge into 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10040][SQL] Use batch insert for JDBC w...

2015-08-20 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/8273#issuecomment-132911504 will this pr be merged into branch-1.5?I need it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10040][SQL] Use batch insert for JDBC w...

2015-08-20 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/8273#issuecomment-132913028 @rxin , thanks for your reply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9199][CORE] Update Tachyon dependency f...

2015-08-17 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/8135#issuecomment-131702682 @calvinjia, but this pr has already been merged into branch-1.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9199][CORE] Update Tachyon dependency f...

2015-08-16 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/8135#issuecomment-131685800 @rxin, why did this pr not merged into master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-05-10 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-100752171 Hi @koeninger , of cource, I can read kafka offset from ZK when recovering by myself, I just want to know that writing to ZK is built-in support or not. --- If your

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-05-10 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-100741128 Hi @jerryshao , current spark version is not built-in support for upgrade and accumulators when recovering from checkpoint, so I want to add kafka offset to zk, and read

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-05-07 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-100077362 is there any conclusion? @jerryshao , could it add a config option to decide whether adding zk offest posting? just my bit suggest:) --- If your project is set up

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-05-07 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-100087287 is there any conclusion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-26 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5428#issuecomment-96484530 hi, @tdas , why this PR was be reverted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-22 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-95387040 @koeninger , will this RP be merged into 1.4.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-21 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-94997887 @koeninger , I test streaming + kakfa 0.8.2.1 with this RP, it works well, :smile: --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-21 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5428#issuecomment-95000892 @tdas , I tested streaming recovering from checkpoint with this PR, it failed if it use accumulators, so this assuredly can't solve [issue SPARK-5206](https

[GitHub] spark pull request: [SPARK-6930][Build]Build with Hive Thrift Serv...

2015-04-15 Thread zzcclp
GitHub user zzcclp opened a pull request: https://github.com/apache/spark/pull/5522 [SPARK-6930][Build]Build with Hive Thrift Server error, because of missing guava change scope of dependency guava to default value : compile You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-6930][Build]Build with Hive Thrift Serv...

2015-04-15 Thread zzcclp
Github user zzcclp closed the pull request at: https://github.com/apache/spark/pull/5522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6930][Build]Build with Hive Thrift Serv...

2015-04-15 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5522#issuecomment-93284488 OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-09 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-91130762 @koeninger , I merge this RP into master and build, it is OK. then run tests as follows: mvn -Pscala-2.10 -Phadoop-2.3 -Pyarn -Dyarn.version=2.3.0-cdh5.1.2

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-09 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5428#issuecomment-91180116 @tdas , can this RP resolve [this issue](https://issues.apache.org/jira/browse/SPARK-5206)? Restart a streaming app from checkpoint incorrectly if using accumulators

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-08 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-91084285 there is not any error, why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-04 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-89694634 @koeninger , I can't visit [this url](https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28872/) , it's 404. ?? --- If your project is set up

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-03-31 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-88331714 @koeninger , no progress yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Hot Fix][SQL] a compilation error in InsertIn...

2015-03-26 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5204#issuecomment-86416823 @witgo , This [PR](https://github.com/apache/spark/pull/5198) has resolved the problem. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-6547][Tests]Missing import Files in Ins...

2015-03-26 Thread zzcclp
GitHub user zzcclp opened a pull request: https://github.com/apache/spark/pull/5200 [SPARK-6547][Tests]Missing import Files in InsertIntoHiveTableSuite.scala Use org.apache.spark.util.Utils instead of Files You can merge this pull request into a Git repository by running

[GitHub] spark pull request: [SPARK-6547][Tests]Missing import Files in Ins...

2015-03-26 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5200#issuecomment-86364511 It is duplicate [PR](https://github.com/apache/spark/pull/5198), close this, please. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-6547][Tests]Missing import Files in Ins...

2015-03-26 Thread zzcclp
Github user zzcclp closed the pull request at: https://github.com/apache/spark/pull/5200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85877991 @chenghao-intel , can you review again, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85882008 @AmplabJenkins , please re test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85911436 Add a newline at the end of source file, does it need to re test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85925500 @AmplabJenkins , please re test, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85936678 OK, I am new sparker, :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-86305650 @liancheng , I already set my real name on my GitHub *Name* and JIRA *Full Name*. :smiley: --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-24 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85805763 @chenghao-intel , I have update the code. can you take a look again. thanks. @AmplabJenkins , re-test --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-24 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85768950 @chenghao-intel ,I have update the code. can you take a look again. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-24 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85797911 @SparkQA , merge again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-24 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85374620 OK, I will modify code and test again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-24 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85389879 @chenghao-intel , I change code and test it, the result is the same as last commit , is 5 minutes. Please help me for checking code. --- If your project is set up

[GitHub] spark pull request: Improve ScalaUdf called performance.

2015-03-23 Thread zzcclp
GitHub user zzcclp opened a pull request: https://github.com/apache/spark/pull/5154 Improve ScalaUdf called performance. As issue SPARK-6483 description, ScalaUdf is low performance because of calling *asInstanceOf* to convert per record. With this, the performance of ScalaUdf

[GitHub] spark pull request: [SPARK-6483][SQL]Improve ScalaUdf called perfo...

2015-03-23 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/5154#issuecomment-85353974 Before this change, it takes 17 minutes, and now takes 5 minutes, which is the same as *HiveContext + udf floor* and *non-udf* --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-03-18 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-82816799 @koeninger , kafka 0.8.2.1 was [released](https://archive.apache.org/dist/kafka/0.8.2.1/RELEASE_NOTES.html), can it be upgrade this version? --- If your project is set

[GitHub] spark pull request: [SPARK-6275][Documentation]Miss toDF() functio...

2015-03-12 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4977#issuecomment-78462093 OK.:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6279][Streaming]In KafkaRDD.scala, Miss...

2015-03-11 Thread zzcclp
GitHub user zzcclp opened a pull request: https://github.com/apache/spark/pull/4979 [SPARK-6279][Streaming]In KafkaRDD.scala, Miss expressions flag s at logging string In KafkaRDD.scala, Miss expressions flag s at logging string In logging file, it print `Beginning offset

[GitHub] spark pull request: [SPARK-6275][Documentation]Miss toDF() functio...

2015-03-11 Thread zzcclp
GitHub user zzcclp opened a pull request: https://github.com/apache/spark/pull/4977 [SPARK-6275][Documentation]Miss toDF() function in docs/sql-programming-guide.md Miss `toDF()` function in docs/sql-programming-guide.md You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

2015-03-03 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4867#issuecomment-77078291 why to close this RP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-02-12 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-74193418 Will this RP be merged into 1.3.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5470][Core]use defaultClassLoader to lo...

2015-01-28 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/4258#issuecomment-71959063 LGTM, I test this with spark-branch 1.2, it works correctly. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

  1   2   >