[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36499: [SPARK-38846][SQL] Add explicit data mapping between Teradata Numeric Type and Spark DecimalType

Eugene-Mark commented on code in PR #36499: URL: https://github.com/apache/spark/pull/36499#discussion_r901863572 ## docs/sql-migration-guide.md: ## @@ -22,6 +22,11 @@ license: | * Table of contents {:toc} +## Upgrading from Spark SQL 3.3 to 3.4 + Review Comment:

[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36499: [SPARK-38846][SQL] Add explicit data mapping between Teradata Numeric Type and Spark DecimalType

Eugene-Mark commented on code in PR #36499: URL: https://github.com/apache/spark/pull/36499#discussion_r891588142 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala: ## @@ -96,4 +97,29 @@ private case object TeradataDialect extends JdbcDialect {

[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36499: [SPARK-38846][SQL] Add explicit data mapping between Teradata Numeric Type and Spark DecimalType

Eugene-Mark commented on code in PR #36499: URL: https://github.com/apache/spark/pull/36499#discussion_r891588142 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala: ## @@ -96,4 +97,29 @@ private case object TeradataDialect extends JdbcDialect {

[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36499: [SPARK-38846][SQL] Add explicit data mapping between Teradata Numeric Type and Spark DecimalType

Eugene-Mark commented on code in PR #36499: URL: https://github.com/apache/spark/pull/36499#discussion_r891528661 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala: ## @@ -96,4 +97,29 @@ private case object TeradataDialect extends JdbcDialect {