[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-12 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r895251697 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not isinstance(x,

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-09 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r894068688 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not isinstance(x,

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-09 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r894039985 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not isinstance(x,

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-08 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r892985507 ## python/pyspark/sql/tests/test_arrow.py: ## @@ -495,6 +509,22 @@ def test_schema_conversion_roundtrip(self): schema_rt = from_arrow_schema(arrow_schema)

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-08 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r892865940 ## python/pyspark/sql/tests/test_arrow.py: ## @@ -495,6 +509,22 @@ def test_schema_conversion_roundtrip(self): schema_rt = from_arrow_schema(arrow_schema)

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-08 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r892865940 ## python/pyspark/sql/tests/test_arrow.py: ## @@ -495,6 +509,22 @@ def test_schema_conversion_roundtrip(self): schema_rt = from_arrow_schema(arrow_schema)

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-07 Thread GitBox
HyukjinKwon commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r891811193 ## python/pyspark/sql/tests/test_session.py: ## @@ -379,6 +381,54 @@ def test_use_custom_class_for_extensions(self): ) +class