[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-09-07 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1240148842 Thanks for your review @mridulm @tgravescs ~ Thanks for helping fix GA @Yikun ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-09-07 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1238988334 > pls rebase this PR, after #37815 merged. Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-09-07 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1238973755 [Run / Base image build](https://github.com/LuciferYang/spark/runs/8220878852?check_suite_focus=true#logs) failed as follows: ``` 2022-09-07T04:35:50.8451091Z #32 exporting

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-09-03 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1236241254 should we merge this one ? @Ngone51 @mridulm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-08-31 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1232555858 Do you have time to further review this one? Thanks @mridulm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-08-28 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1229703838 > Removed [WIP], and need @Ngone51 confirm whether there are new comments of #36200. > > And I have a point to discuss: > > There are two `initLevelDB` method in

[GitHub] [spark] LuciferYang commented on pull request #37648: [SPARK-38909][BUILD][CORE][YARN][FOLLOWUP] Make some code cleanup related to shuffle state db

2022-08-26 Thread GitBox
LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1229100012 Removed [WIP], and need @Ngone51 confirm whether there are new comments of https://github.com/apache/spark/pull/36200. And I have a point to discuss: There are two