[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

2020-11-15 Thread GitBox
Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523862805 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -158,6 +158,34 @@ public void

[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

2020-11-14 Thread GitBox
Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523715366 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -181,7 +181,8 @@ public void

[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

2020-11-14 Thread GitBox
Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523709402 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/MergeFinalizerListener.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

2020-10-27 Thread GitBox
Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r513080596 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -158,6 +158,42 @@ public void