[GitHub] [spark] amaliujia commented on a diff in pull request #38409: [SPARK-40930][CONNECT] Support Collect() in Python client

2022-11-01 Thread GitBox
amaliujia commented on code in PR #38409: URL: https://github.com/apache/spark/pull/38409#discussion_r1010931805 ## python/pyspark/sql/connect/dataframe.py: ## @@ -305,8 +308,12 @@ def _print_plan(self) -> str: return self._plan.print() return "" -

[GitHub] [spark] amaliujia commented on a diff in pull request #38409: [SPARK-40930][CONNECT] Support Collect() in Python client

2022-11-01 Thread GitBox
amaliujia commented on code in PR #38409: URL: https://github.com/apache/spark/pull/38409#discussion_r1010931805 ## python/pyspark/sql/connect/dataframe.py: ## @@ -305,8 +308,12 @@ def _print_plan(self) -> str: return self._plan.print() return "" -

[GitHub] [spark] amaliujia commented on a diff in pull request #38409: [SPARK-40930][CONNECT] Support Collect() in Python client

2022-10-30 Thread GitBox
amaliujia commented on code in PR #38409: URL: https://github.com/apache/spark/pull/38409#discussion_r1009013217 ## python/pyspark/sql/connect/dataframe.py: ## @@ -305,8 +308,12 @@ def _print_plan(self) -> str: return self._plan.print() return "" -