amaliujia commented on code in PR #38418:
URL: https://github.com/apache/spark/pull/38418#discussion_r1010890792
##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1001,7 +1001,13 @@ createOrReplaceTableColTypeList
;
createOrReplaceTableColType
- : colName=errorCapturingIdentifier dataType (NOT NULL)? defaultExpression?
commentSpec?
+ : colName=errorCapturingIdentifier dataType colDefinitionOption*
Review Comment:
Sorry for the late comment:
Just to confirm, does this change extend the options support? Looks like in
the past there is an ordering for those options (`NOT NULL` first, default
values next, comment spec last) but with this PR, there is no such ordering
anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
