[GitHub] [spark] amaliujia commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL

2022-11-03 Thread GitBox
amaliujia commented on PR #38475: URL: https://github.com/apache/spark/pull/38475#issuecomment-1302727166 To have select with alias, we need to know the previous schema first. I think it is covered by my previous comment if you were talking about the same thing

[GitHub] [spark] amaliujia commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL

2022-11-01 Thread GitBox
amaliujia commented on PR #38475: URL: https://github.com/apache/spark/pull/38475#issuecomment-1299371686 @cloud-fan This is a good example that one API can be implemented with or without a plan. Basically if we don't add a new plan to the proto, clients can still implement