[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891876268 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,9 +667,10 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891840233 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,9 +667,10 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891839935 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,9 +667,10 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891224222 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,9 +667,10 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891099418 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,9 +667,10 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-01 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r886731669 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala: ## @@ -319,7 +320,8 @@ abstract class StreamExecution( // This is

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r886278462 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,10 +669,7 @@ abstract class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885677872 ## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ## @@ -486,4 +489,22 @@ object QueryExecution { val preparationRules =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885675714 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -1376,6 +1376,13 @@ class

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885674491 ## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ## @@ -486,4 +489,22 @@ object QueryExecution { val preparationRules =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
cloud-fan commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885671871 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -1401,6 +1408,14 @@ class