[GitHub] [spark] cloud-fan commented on a diff in pull request #38461: [SPARK-34079][SQL][FOLLOWUP] Improve the readability and simplify the code for MergeScalarSubqueries

2022-11-02 Thread GitBox
cloud-fan commented on code in PR #38461: URL: https://github.com/apache/spark/pull/38461#discussion_r1011363681 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -346,25 +346,20 @@ object MergeScalarSubqueries extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38461: [SPARK-34079][SQL][FOLLOWUP] Improve the readability and simplify the code for MergeScalarSubqueries

2022-11-02 Thread GitBox
cloud-fan commented on code in PR #38461: URL: https://github.com/apache/spark/pull/38461#discussion_r1011362750 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -346,25 +346,20 @@ object MergeScalarSubqueries extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38461: [SPARK-34079][SQL][FOLLOWUP] Improve the readability and simplify the code for MergeScalarSubqueries

2022-11-01 Thread GitBox
cloud-fan commented on code in PR #38461: URL: https://github.com/apache/spark/pull/38461#discussion_r1010607741 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -346,25 +346,19 @@ object MergeScalarSubqueries extends