[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-10-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-705305987 There was an attempt to backport this fix but we decided not to as it breaks backward compatibility. See https://github.com/apache/spark/pull/29448#issuecomment-674723823

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-08 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655336987 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655294615 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259660 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259298 > So now we have UnsafeRow.setDecimal silently returns a null for an overflowed decimal value in setDecimal, but getDecimal throws error. There is inconsistency here. Why is

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-654979274 cc @skambha @rednaxelafx @viirya This is an automated message from the Apache Git Service. To respond to the