[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-28 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r738475547 ## File path: python/pyspark/streaming/kinesis.py ## @@ -14,17 +14,21 @@ # See the License for the specific language governing permissions and #

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-28 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r738217455 ## File path: python/pyspark/streaming/kinesis.py ## @@ -47,10 +47,10 @@ def createStream( regionName: str, initialPositionInStream: str,

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-28 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r738197128 ## File path: python/pyspark/streaming/listener.py ## @@ -15,63 +15,66 @@ # limitations under the License. # +from typing import Any + + __all__ =

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-27 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r737989238 ## File path: python/pyspark/streaming/kinesis.py ## @@ -34,11 +38,65 @@ def utf8_decoder(s): class KinesisUtils(object): @staticmethod -def

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-25 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r736118182 ## File path: python/pyspark/streaming/kinesis.py ## @@ -14,17 +14,21 @@ # See the License for the specific language governing permissions and #

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-22 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r734399027 ## File path: python/pyspark/streaming/kinesis.py ## @@ -14,17 +14,21 @@ # See the License for the specific language governing permissions and #

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-21 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r734229556 ## File path: python/pyspark/streaming/kinesis.py ## @@ -34,11 +38,22 @@ def utf8_decoder(s): class KinesisUtils(object): @staticmethod -def

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-21 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r734210281 ## File path: python/pyspark/streaming/kinesis.py ## @@ -34,11 +38,22 @@ def utf8_decoder(s): class KinesisUtils(object): @staticmethod -def

[GitHub] [spark] dchvn commented on a change in pull request #34323: [SPARK-37042][PYTHON] Inline type hints for kinesis.py and listener.py in python/pyspark/streaming

2021-10-21 Thread GitBox
dchvn commented on a change in pull request #34323: URL: https://github.com/apache/spark/pull/34323#discussion_r734152016 ## File path: python/pyspark/streaming/kinesis.py ## @@ -34,11 +38,22 @@ def utf8_decoder(s): class KinesisUtils(object): @staticmethod -def