[GitHub] [spark] dchvn commented on pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2022-01-19 Thread GitBox
dchvn commented on pull request #34363: URL: https://github.com/apache/spark/pull/34363#issuecomment-1017093623 > > sorry I completely missed the context here. What's the status now? > > So far, there is no response to issue on mypy tracker, but we can be fairly sure that the issue

[GitHub] [spark] dchvn commented on pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-12-12 Thread GitBox
dchvn commented on pull request #34363: URL: https://github.com/apache/spark/pull/34363#issuecomment-992108195 @zero323 Do you have any ideas to resolve this PR? Should I keep both `__add__` and `__iadd__` or follow your suggestion? -- This is an automated message from the Apache Git

[GitHub] [spark] dchvn commented on pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

2021-10-21 Thread GitBox
dchvn commented on pull request #34363: URL: https://github.com/apache/spark/pull/34363#issuecomment-949283715 CC @xinrong-databricks @HyukjinKwon @ueshin @zero323. FYI. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to