[GitHub] [spark] dongjoon-hyun commented on pull request #31533: [SPARK-34407][K8S] KubernetesClusterSchedulerBackend.stop should clean up K8s resources

2021-02-08 Thread GitBox
dongjoon-hyun commented on pull request #31533: URL: https://github.com/apache/spark/pull/31533#issuecomment-775689562 Merged to master/3.1/3.0/2.4. This is not a blocker for RC vote. cc @HyukjinKwon This is an automated

[GitHub] [spark] dongjoon-hyun commented on pull request #31533: [SPARK-34407][K8S] KubernetesClusterSchedulerBackend.stop should clean up K8s resources

2021-02-08 Thread GitBox
dongjoon-hyun commented on pull request #31533: URL: https://github.com/apache/spark/pull/31533#issuecomment-775665857 Sorry for updating after approval. I just simplified the test code like the following. ```scala - val backend = spy(schedulerBackendUnderTest) - backend.start()

[GitHub] [spark] dongjoon-hyun commented on pull request #31533: [SPARK-34407][K8S] KubernetesClusterSchedulerBackend.stop should clean up K8s resources

2021-02-08 Thread GitBox
dongjoon-hyun commented on pull request #31533: URL: https://github.com/apache/spark/pull/31533#issuecomment-775664594 Thank you so much, @viirya ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #31533: [SPARK-34407][K8S] KubernetesClusterSchedulerBackend.stop should clean up K8s resources

2021-02-08 Thread GitBox
dongjoon-hyun commented on pull request #31533: URL: https://github.com/apache/spark/pull/31533#issuecomment-775663233 Could you review this, @viirya ? This is an automated message from the Apache Git Service. To respond to