[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-15 Thread GitBox
dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-659086163 I guess we can forbid that too consistently as a continuation of this approach. BTW, until now, it's beyond of the scope because this PR was designed to prevent

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-13 Thread GitBox
dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-657383898 Hi, @ulysses-you . We already choose the plan. This is a step to forbid that gracefully. For `create view v1 as select null as col`, we can add an

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655295006 Could you make a follow-up(full revert or partial revert) as what you suggest, @HyukjinKwon ?

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655291242 First of all, it's not a good idea to add `NullType` into a new Spark datatype officially. Not only the exposure causes more complexity, but also what can we do in

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655234096 Merged to master. Thank you for your patience, @LantaoJin . (The last commit is only about HiveDDLSuite. I tested it locally.)