[GitHub] [spark] grundprinzip commented on pull request #38470: [CONNECT] [DOC] Defining Spark Connect Client Connection String

2022-11-02 Thread GitBox
grundprinzip commented on PR #38470: URL: https://github.com/apache/spark/pull/38470#issuecomment-1299977630 @HyukjinKwon so my proposal is the following: * I moved the README from the pyspark folder into the top-level `connector/connect` directory and made it clear that these are

[GitHub] [spark] grundprinzip commented on pull request #38470: [CONNECT] [DOC] Defining Spark Connect Client Connection String

2022-11-02 Thread GitBox
grundprinzip commented on PR #38470: URL: https://github.com/apache/spark/pull/38470#issuecomment-1299629632 What about we link to it from the top level Readme in the component? The reason why it's not in the code is because it's client language agnostic. -- This is an automated

[GitHub] [spark] grundprinzip commented on pull request #38470: [CONNECT] [DOC] Defining Spark Connect Client Connection String

2022-11-01 Thread GitBox
grundprinzip commented on PR #38470: URL: https://github.com/apache/spark/pull/38470#issuecomment-1299609859 @HyukjinKwon I will add a Jira this is just the starting point to align where we want to go. My idea would be that once this is merged I will create a pr for the python

[GitHub] [spark] grundprinzip commented on pull request #38470: [CONNECT] [DOC] Defining Spark Connect Client Connection String

2022-11-01 Thread GitBox
grundprinzip commented on PR #38470: URL: https://github.com/apache/spark/pull/38470#issuecomment-1299084859 Good point, I will incorporate that into the doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL