[GitHub] [spark] heyihong commented on a diff in pull request #42987: [SPARK-45207][SQL][CONNECT] Implement Error Enrichment for Scala Client

2023-09-22 Thread via GitHub
heyihong commented on code in PR #42987: URL: https://github.com/apache/spark/pull/42987#discussion_r1334246788 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -93,33 +184,63 @@ private[client] object

[GitHub] [spark] heyihong commented on a diff in pull request #42987: [SPARK-45207][SQL][CONNECT] Implement Error Enrichment for Scala Client

2023-09-22 Thread via GitHub
heyihong commented on code in PR #42987: URL: https://github.com/apache/spark/pull/42987#discussion_r1334246788 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -93,33 +184,63 @@ private[client] object

[GitHub] [spark] heyihong commented on a diff in pull request #42987: [SPARK-45207][SQL][CONNECT] Implement Error Enrichment for Scala Client

2023-09-20 Thread via GitHub
heyihong commented on code in PR #42987: URL: https://github.com/apache/spark/pull/42987#discussion_r1331977811 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -2882,8 +2882,7 @@ object SQLConf { "level settings.")