itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1732912031
LGTM now.
Thanks for your consistent work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1728575805
Yeah, mypy check always tricky Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1726767540
@dzhigimont Can we just make the CI pass for now? I can help in the
follow-ups after merging this one.
Seems like the mypy checks is failing for now:
```
starting mypy
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1693074343
No worries! I ping you just for reminder :-) Please take your time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1692633152
@dzhigimont Could you proceed this PR if you're still interested on this
work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1528926660
Can you rebase to master and try running linter again??
If the problem still exists, yes, let's fix the `mypy` failure. We should
make the PR pass the CI anyway.
--
This is an
itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1524465392
Could you resolve mypy check? You can run the static analysis by running
`dev/lint-python` locally.
--
This is an automated message from the Apache Git Service.
To respond to the
