[GitHub] [spark] maropu commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

2021-06-30 Thread GitBox
maropu commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871855840 Is it difficult to add some tests for this change? The fix itself seems fine to me. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

2021-06-29 Thread GitBox
maropu commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-869682789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] maropu commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

2021-06-28 Thread GitBox
maropu commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-869682789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To