[GitHub] [spark] mridulm commented on pull request #33063: [SPARK-35879][Core][Shuffle] Fix performance regression caused by collectFetchRequests

mridulm commented on pull request #33063: URL: https://github.com/apache/spark/pull/33063#issuecomment-869029335 Thanks @yaooqinn ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] mridulm commented on pull request #33063: [SPARK-35879][Core][Shuffle] Fix performance regression caused by collectFetchRequests

mridulm commented on pull request #33063: URL: https://github.com/apache/spark/pull/33063#issuecomment-868827146 @dongjoon-hyun I am +1 on the change if the performance is still good based on @yaooqinn's benchmark (will be going on vacation soon, so dont want reviews to be blocked on my

[GitHub] [spark] mridulm commented on pull request #33063: [SPARK-35879][Core][Shuffle] Fix performance regression caused by collectFetchRequests

mridulm commented on pull request #33063: URL: https://github.com/apache/spark/pull/33063#issuecomment-868824419 Thanks for the changes @yaooqinn and thanks for the ping @dongjoon-hyun :-) The changes look good - but I want to make sure we still have similar performance benefits as we