[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r892641206 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -73,18 +73,20 @@ private[spark] object SparkThrowableHelper { def getMessage( errorClass:

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891606582 ## sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala: ## @@ -36,13 +36,31 @@ class AnalysisException protected[sql] ( @transient val plan:

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891425678 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -39,11 +39,17 @@ public SparkOutOfMemoryError(OutOfMemoryError e) { } public

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891425369 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with an

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891404260 ## sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala: ## @@ -36,13 +36,31 @@ class AnalysisException protected[sql] ( @transient val plan:

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891395982 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with an

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891389538 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -98,6 +100,29 @@ private[spark] object SparkThrowableHelper { s"[$displayClass]

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891373947 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -39,11 +39,17 @@ public SparkOutOfMemoryError(OutOfMemoryError e) { } public

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891355010 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with an

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891349846 ## core/src/main/resources/error/error-classes.json: ## @@ -333,7 +332,7 @@ }, "SECOND_FUNCTION_ARGUMENT_NOT_INTEGER" : { "message" : [ - "The second

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890414735 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -46,4 +49,13 @@ default String getSqlState() { default boolean isInternalError() { return

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890413958 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -46,4 +49,13 @@ default String getSqlState() { default boolean isInternalError() { return

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890413958 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -46,4 +49,13 @@ default String getSqlState() { default boolean isInternalError() { return

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890411559 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -35,6 +35,9 @@ public interface SparkThrowable { // Succinct, human-readable, unique, and

[GitHub] [spark] srielau commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

srielau commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890410763 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -28,6 +28,7 @@ @Private public final class SparkOutOfMemoryError extends