[GitHub] [spark] srowen commented on a diff in pull request #37771: [SPARK-40315][SQL] Add equals() and hashCode() to ArrayBasedMapData

2022-09-03 Thread GitBox
srowen commented on code in PR #37771: URL: https://github.com/apache/spark/pull/37771#discussion_r962166466 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala: ## @@ -35,6 +37,29 @@ class ArrayBasedMapData(val keyArray: ArrayData, val

[GitHub] [spark] srowen commented on a diff in pull request #37771: [SPARK-40315][SQL] Add equals() and hashCode() to ArrayBasedMapData

2022-09-03 Thread GitBox
srowen commented on code in PR #37771: URL: https://github.com/apache/spark/pull/37771#discussion_r962166373 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilderSuite.scala: ## @@ -142,4 +142,36 @@ class ArrayBasedMapBuilderSuite extends